Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add scheduling framework extender #365

Conversation

saintube
Copy link
Member

Signed-off-by: saintube saintube@foxmail.com

Ⅰ. Describe what this PR does

add a framework extender for the koord-scheduler, which enables us to extend the native frameworkImpl methods (RunPreFilterPlugins, RunFilterPlugins, ...)

Ⅱ. Does this pull request fix one issue?

partially for #188

Ⅲ. Describe how to verify it

Ⅳ. Special notes for reviews

V. Checklist

  • I have written necessary docs and comments
  • I have added necessary unit tests and integration tests
  • All checks passed in make test

Signed-off-by: saintube <saintube@foxmail.com>
@codecov
Copy link

codecov bot commented Jul 13, 2022

Codecov Report

Merging #365 (c057043) into main (b2fcc22) will increase coverage by 0.06%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main     #365      +/-   ##
==========================================
+ Coverage   66.12%   66.18%   +0.06%     
==========================================
  Files         116      116              
  Lines       11557    11557              
==========================================
+ Hits         7642     7649       +7     
+ Misses       3329     3322       -7     
  Partials      586      586              
Flag Coverage Δ
unittests 66.18% <ø> (+0.06%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/koordlet/runtimehooks/reconciler/reconciler.go 78.94% <0.00%> (+7.36%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b2fcc22...c057043. Read the comment docs.

Copy link
Member

@eahydra eahydra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@hormes
Copy link
Member

hormes commented Jul 14, 2022

/approve

@koordinator-bot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hormes

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@koordinator-bot koordinator-bot bot merged commit 993fc21 into koordinator-sh:main Jul 14, 2022
@jasonliu747 jasonliu747 added this to the v0.6 milestone Jul 19, 2022
jasonliu747 pushed a commit to jasonliu747/koordinator that referenced this pull request Jul 26, 2022
Signed-off-by: saintube <saintube@foxmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants