Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add descheduler framework proposal #371

Merged
merged 1 commit into from
Jul 20, 2022

Conversation

eahydra
Copy link
Member

@eahydra eahydra commented Jul 15, 2022

Signed-off-by: Joseph joseph.t.lee@outlook.com

Ⅰ. Describe what this PR does

This proposal is based on the K8s community's descheduler to design and implement the descheduler framework required by the koordinator.

Ⅱ. Does this pull request fix one issue?

fix #213

Ⅲ. Describe how to verify it

Ⅳ. Special notes for reviews

V. Checklist

  • I have written necessary docs and comments
  • I have added necessary unit tests and integration tests
  • All checks passed in make test

@eahydra eahydra marked this pull request as ready for review July 15, 2022 07:42
@eahydra eahydra added this to the v0.6 milestone Jul 15, 2022
@codecov
Copy link

codecov bot commented Jul 15, 2022

Codecov Report

Merging #371 (1643a0d) into main (dab5a92) will increase coverage by 0.05%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main     #371      +/-   ##
==========================================
+ Coverage   66.50%   66.56%   +0.05%     
==========================================
  Files         116      116              
  Lines       11669    11669              
==========================================
+ Hits         7760     7767       +7     
+ Misses       3308     3301       -7     
  Partials      601      601              
Flag Coverage Δ
unittests 66.56% <ø> (+0.05%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/koordlet/runtimehooks/reconciler/reconciler.go 78.94% <0.00%> (+7.36%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dab5a92...1643a0d. Read the comment docs.

@eahydra eahydra requested review from allwmh, hormes, saintube and zwzhang0107 and removed request for FillZpp and yihuifeng July 15, 2022 08:14
Copy link
Member

@jasonliu747 jasonliu747 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
Nice job!

Signed-off-by: Joseph <joseph.t.lee@outlook.com>
Copy link
Member

@jasonliu747 jasonliu747 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@koordinator-bot koordinator-bot bot added the lgtm label Jul 20, 2022
@saintube
Copy link
Member

/lgtm

@hormes
Copy link
Member

hormes commented Jul 20, 2022

/approve

@koordinator-bot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hormes

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@koordinator-bot koordinator-bot bot merged commit d1fb8c5 into koordinator-sh:main Jul 20, 2022
jasonliu747 pushed a commit to jasonliu747/koordinator that referenced this pull request Jul 26, 2022
Signed-off-by: Joseph <joseph.t.lee@outlook.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants