Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change Kubebuilder RBAC Annotation Groups #38

Merged
merged 3 commits into from
Apr 7, 2022
Merged

Change Kubebuilder RBAC Annotation Groups #38

merged 3 commits into from
Apr 7, 2022

Conversation

Mr-Linus
Copy link
Contributor

@Mr-Linus Mr-Linus commented Apr 6, 2022

Ⅰ. Describe what this PR does

Ⅱ. Does this pull request fix one issue?

Ⅲ. Describe how to verify it

Ⅳ. Special notes for reviews

jasonliu747
jasonliu747 reviewed Apr 6, 2022
View reviewed changes
Copy link
Member

@jasonliu747 jasonliu747 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch, thanks for your contribution!
Btw, please follow the instruction to fix DCO error.

@Mr-Linus Mr-Linus force-pushed the patch-1 branch 3 times, most recently from ae18a68 to fc046db Compare April 6, 2022 12:19
@Mr-Linus
update kubebuilder annotations
482514a 
Signed-off-by: mr-linus <mrfunky001@gmail.com>
@Mr-Linus
Copy link
Contributor Author

Mr-Linus commented Apr 6, 2022

Nice catch, thanks for your contribution! Btw, please follow the instruction to fix DCO error.

Fixed it.

@jasonliu747
Copy link
Member

@FillZpp CI keeps failing, PTAL.

@Mr-Linus
update golangci-lint version to v1.45.2
ca76843 
Signed-off-by: mr-linus <mrfunky001@gmail.com>
@Mr-Linus
Copy link
Contributor Author

Mr-Linus commented Apr 6, 2022

@FillZpp CI keeps failing, PTAL.

@jasonliu747 It seems that the ci version causes the failing,because the Merged PR#41 still has the problem.I try to update the ci version to 1.45 and fixed it.

@jasonliu747
Copy link
Member

@jasonliu747 It seems that the ci version causes the failing,because the Merged PR#41 still has the problem.I try to update the ci version to 1.45 and fixed it.

That’s weird, it worked fine last week. Thanks for the fix though.
/lgtm

@koordinator-bot koordinator-bot bot added the lgtm label Apr 6, 2022
@koordinator-bot koordinator-bot bot removed the lgtm label Apr 7, 2022
jasonliu747
jasonliu747 approved these changes Apr 7, 2022
View reviewed changes
Copy link
Member

@jasonliu747 jasonliu747 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@koordinator-bot koordinator-bot bot added the lgtm label Apr 7, 2022
@hormes
Copy link
Member

hormes commented Apr 7, 2022

/approve

@koordinator-bot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hormes, jasonliu747

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@koordinator-bot koordinator-bot bot merged commit 4158c6f into koordinator-sh:main Apr 7, 2022
@Mr-Linus Mr-Linus mentioned this pull request Apr 18, 2022
Closed
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jasonliu747 jasonliu747 jasonliu747 approved these changes

@zwzhang0107 zwzhang0107 Awaiting requested review from zwzhang0107

Assignees

@jasonliu747 jasonliu747

Labels
approved lgtm size/XS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Mr-Linus @jasonliu747 @hormes