-
Notifications
You must be signed in to change notification settings - Fork 315
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
koordlet: optimize auditor UT with httptest.Server #382
koordlet: optimize auditor UT with httptest.Server #382
Conversation
90e7fb1
to
3d1afcc
Compare
Codecov Report
@@ Coverage Diff @@
## main #382 +/- ##
==========================================
- Coverage 66.57% 66.55% -0.02%
==========================================
Files 116 116
Lines 11580 11580
==========================================
- Hits 7709 7707 -2
- Misses 3281 3283 +2
Partials 590 590
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
Signed-off-by: wangjianyu <zmsjianyu@gmail.com>
3d1afcc
to
3e1627d
Compare
/approve |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: eahydra, hormes, jasonliu747 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Signed-off-by: wangjianyu <zmsjianyu@gmail.com>
Ⅰ. Describe what this PR does
Ⅱ. Does this pull request fix one issue?
Ⅲ. Describe how to verify it
Ⅳ. Special notes for reviews
V. Checklist
make test