Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature: report pod alloc of Guaranteed pod and cpu manager policy #386

Merged
merged 1 commit into from
Jul 25, 2022

Conversation

ZYecho
Copy link
Contributor

@ZYecho ZYecho commented Jul 20, 2022

Signed-off-by: Yue Zhang huaihuan.zy@alibaba-inc.com

Ⅰ. Describe what this PR does

Ⅱ. Does this pull request fix one issue?

Ⅲ. Describe how to verify it

Ⅳ. Special notes for reviews

V. Checklist

  • I have written necessary docs and comments
  • I have added necessary unit tests and integration tests
  • All checks passed in make test

@koordinator-bot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To complete the pull request process, please assign hormes after the PR has been reviewed.
You can assign the PR to them by writing /assign @hormes in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ZYecho ZYecho force-pushed the report-static branch 4 times, most recently from 23386e8 to 5ea8f2f Compare July 21, 2022 02:07
@codecov
Copy link

codecov bot commented Jul 21, 2022

Codecov Report

Merging #386 (b68ddc4) into main (f32a0ba) will increase coverage by 0.14%.
The diff coverage is 43.90%.

@@            Coverage Diff             @@
##             main     #386      +/-   ##
==========================================
+ Coverage   66.06%   66.20%   +0.14%     
==========================================
  Files         118      119       +1     
  Lines       12004    12135     +131     
==========================================
+ Hits         7930     8034     +104     
- Misses       3455     3474      +19     
- Partials      619      627       +8     
Flag Coverage Δ
unittests 66.20% <43.90%> (+0.14%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/util/system/cpu_manager_linux.go 0.00% <0.00%> (ø)
...dlet/statesinformer/states_noderesourcetopology.go 64.17% <61.01%> (+0.66%) ⬆️
pkg/koordlet/runtimehooks/reconciler/reconciler.go 78.94% <0.00%> (-2.11%) ⬇️
pkg/koordlet/metricsadvisor/collector_gpu.go 36.31% <0.00%> (-1.43%) ⬇️
pkg/koordlet/resmanager/cpu_suppress.go 72.92% <0.00%> (-0.29%) ⬇️
pkg/koordlet/metriccache/storage_tables.go 57.14% <0.00%> (ø)
pkg/koordlet/metricsadvisor/collector.go 9.48% <0.00%> (+0.02%) ⬆️
pkg/koordlet/metriccache/metric_cache.go 52.04% <0.00%> (+2.46%) ⬆️
pkg/koordlet/reporter/reporter.go 54.19% <0.00%> (+16.14%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f32a0ba...b68ddc4. Read the comment docs.

apis/extension/node.go Outdated Show resolved Hide resolved
pkg/util/system/cpu_manager_linux.go Show resolved Hide resolved
apis/extension/node.go Show resolved Hide resolved
Signed-off-by: Yue Zhang <huaihuan.zy@alibaba-inc.com>
@zwzhang0107
Copy link
Contributor

/lgtm

@koordinator-bot koordinator-bot bot added the lgtm label Jul 25, 2022
@hormes hormes merged commit 488f8d5 into koordinator-sh:main Jul 25, 2022
@ZYecho ZYecho deleted the report-static branch July 25, 2022 09:27
jasonliu747 pushed a commit to jasonliu747/koordinator that referenced this pull request Jul 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants