Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bugfix: always need to reset cpuset when cpu supress #403

Merged
merged 1 commit into from
Jul 25, 2022

Conversation

ZYecho
Copy link
Contributor

@ZYecho ZYecho commented Jul 25, 2022

Signed-off-by: Yue Zhang huaihuan.zy@alibaba-inc.com

Ⅰ. Describe what this PR does

fix cfsquota to keep with be share pool,(exclude lse pod)
and remove status judgement to keep recover always work

Ⅱ. Does this pull request fix one issue?

Ⅲ. Describe how to verify it

Ⅳ. Special notes for reviews

V. Checklist

  • I have written necessary docs and comments
  • I have added necessary unit tests and integration tests
  • All checks passed in make test

@codecov
Copy link

codecov bot commented Jul 25, 2022

Codecov Report

Merging #403 (9a9923d) into main (5b320c0) will decrease coverage by 0.03%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #403      +/-   ##
==========================================
- Coverage   66.36%   66.33%   -0.04%     
==========================================
  Files         118      118              
  Lines       12063    12059       -4     
==========================================
- Hits         8006     7999       -7     
- Misses       3434     3436       +2     
- Partials      623      624       +1     
Flag Coverage Δ
unittests 66.33% <100.00%> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/koordlet/resmanager/cpu_suppress.go 72.92% <100.00%> (-0.29%) ⬇️
pkg/util/system/common_linux.go 53.84% <0.00%> (-3.85%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5b320c0...9a9923d. Read the comment docs.

Signed-off-by: Yue Zhang <huaihuan.zy@alibaba-inc.com>
@zwzhang0107
Copy link
Contributor

/lgtm

Copy link
Member

@jasonliu747 jasonliu747 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@hormes
Copy link
Member

hormes commented Jul 25, 2022

/approve

@koordinator-bot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hormes

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@koordinator-bot koordinator-bot bot merged commit 0faf65e into koordinator-sh:main Jul 25, 2022
@ZYecho ZYecho deleted the fix-supress branch July 25, 2022 07:42
jasonliu747 pushed a commit to jasonliu747/koordinator that referenced this pull request Jul 26, 2022
)

Signed-off-by: Yue Zhang <huaihuan.zy@alibaba-inc.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants