Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

koordlet: fix build error caused by GPU #413

Merged
merged 1 commit into from
Jul 27, 2022

Conversation

eahydra
Copy link
Member

@eahydra eahydra commented Jul 26, 2022

Signed-off-by: Joseph joseph.t.lee@outlook.com

Ⅰ. Describe what this PR does

Ⅱ. Does this pull request fix one issue?

Ⅲ. Describe how to verify it

Ⅳ. Special notes for reviews

V. Checklist

  • I have written necessary docs and comments
  • I have added necessary unit tests and integration tests
  • All checks passed in make test

Signed-off-by: Joseph <joseph.t.lee@outlook.com>
@eahydra eahydra modified the milestone: v0.6 Jul 26, 2022
@zwzhang0107
Copy link
Contributor

/lgtm

Copy link
Member

@jasonliu747 jasonliu747 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Copy link
Contributor

@LambdaHJ LambdaHJ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@koordinator-bot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by: jasonliu747, LambdaHJ

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@codecov
Copy link

codecov bot commented Jul 26, 2022

Codecov Report

Merging #413 (dfdae15) into main (779ac80) will not change coverage.
The diff coverage is 36.84%.

@@           Coverage Diff           @@
##             main     #413   +/-   ##
=======================================
  Coverage   66.18%   66.18%           
=======================================
  Files         119      120    +1     
  Lines       12136    12136           
=======================================
  Hits         8032     8032           
  Misses       3477     3477           
  Partials      627      627           
Flag Coverage Δ
unittests 66.18% <36.84%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/koordlet/metricsadvisor/collector_gpu.go 0.00% <ø> (-34.62%) ⬇️
pkg/koordlet/metricsadvisor/collector_gpu_linux.go 36.84% <36.84%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 779ac80...dfdae15. Read the comment docs.

@jasonliu747 jasonliu747 marked this pull request as draft July 26, 2022 14:24
@eahydra eahydra marked this pull request as ready for review July 27, 2022 02:33
@hormes hormes merged commit 7442bc5 into koordinator-sh:main Jul 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants