Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cri-runtime-proxy: fix containerErr error when failOver pods and cont… #414

Merged
merged 1 commit into from
Jul 27, 2022

Conversation

lx1036
Copy link
Contributor

@lx1036 lx1036 commented Jul 27, 2022

Ⅰ. Describe what this PR does

fix the error typo.

@codecov
Copy link

codecov bot commented Jul 27, 2022

Codecov Report

Merging #414 (a7c1824) into main (7442bc5) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #414   +/-   ##
=======================================
  Coverage   66.18%   66.18%           
=======================================
  Files         120      120           
  Lines       12136    12136           
=======================================
  Hits         8032     8032           
  Misses       3477     3477           
  Partials      627      627           
Flag Coverage Δ
unittests 66.18% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7442bc5...a7c1824. Read the comment docs.

@jasonliu747
Copy link
Member

@lx1036 please follow the instruction to sign off your commit, thanks.
image

…ainers

Signed-off-by: Xiang Liu <lx1036@126.com>
@lx1036
Copy link
Contributor Author

lx1036 commented Jul 27, 2022

@jasonliu747

have signed-off, thanks.

Copy link
Member

@jasonliu747 jasonliu747 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@koordinator-bot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by: jasonliu747

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@koordinator-bot koordinator-bot bot merged commit 6e0d88f into koordinator-sh:main Jul 27, 2022
@lx1036 lx1036 deleted the patch-1 branch July 27, 2022 07:28
jasonliu747 pushed a commit to jasonliu747/koordinator that referenced this pull request Jul 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants