Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make slo configmap name configurable #415

Merged
merged 1 commit into from
Jul 27, 2022
Merged

make slo configmap name configurable #415

merged 1 commit into from
Jul 27, 2022

Conversation

zwzhang0107
Copy link
Contributor

@zwzhang0107 zwzhang0107 commented Jul 27, 2022

Signed-off-by: 佑祎 zzw261520@alibaba-inc.com

Ⅰ. Describe what this PR does

Ⅱ. Does this pull request fix one issue?

Ⅲ. Describe how to verify it

Ⅳ. Special notes for reviews

V. Checklist

  • I have written necessary docs and comments
  • I have added necessary unit tests and integration tests
  • All checks passed in make test

Signed-off-by: 佑祎 <zzw261520@alibaba-inc.com>
@codecov
Copy link

codecov bot commented Jul 27, 2022

Codecov Report

Merging #415 (4c40859) into main (6e0d88f) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main     #415   +/-   ##
=======================================
  Coverage   66.12%   66.13%           
=======================================
  Files         120      120           
  Lines       12136    12139    +3     
=======================================
+ Hits         8025     8028    +3     
  Misses       3484     3484           
  Partials      627      627           
Flag Coverage Δ
unittests 66.13% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/slo-controller/config/config.go 91.80% <100.00%> (+0.42%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6e0d88f...4c40859. Read the comment docs.

@hormes
Copy link
Member

hormes commented Jul 27, 2022

/approve

@koordinator-bot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hormes

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link
Member

@jasonliu747 jasonliu747 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@koordinator-bot koordinator-bot bot added the lgtm label Jul 27, 2022
@koordinator-bot koordinator-bot bot merged commit 7510a3a into koordinator-sh:main Jul 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants