Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

koord-descheduler: implement descheduling framework #423

Merged

Conversation

eahydra
Copy link
Member

@eahydra eahydra commented Aug 1, 2022

Signed-off-by: Joseph joseph.t.lee@outlook.com

Ⅰ. Describe what this PR does

implement #196 #213

Ⅱ. Does this pull request fix one issue?

Ⅲ. Describe how to verify it

Ⅳ. Special notes for reviews

V. Checklist

  • I have written necessary docs and comments
  • I have added necessary unit tests and integration tests
  • All checks passed in make test

@koordinator-bot koordinator-bot bot requested a review from FillZpp August 1, 2022 08:27
@eahydra eahydra added this to the v0.6 milestone Aug 1, 2022
@codecov
Copy link

codecov bot commented Aug 1, 2022

Codecov Report

Merging #423 (9d60728) into main (827bd6b) will increase coverage by 1.02%.
The diff coverage is 87.46%.

@@            Coverage Diff             @@
##             main     #423      +/-   ##
==========================================
+ Coverage   66.75%   67.77%   +1.02%     
==========================================
  Files         128      134       +6     
  Lines       13579    14297     +718     
==========================================
+ Hits         9064     9690     +626     
- Misses       3824     3893      +69     
- Partials      691      714      +23     
Flag Coverage Δ
unittests 67.77% <87.46%> (+1.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/descheduler/utils/predicates.go 80.57% <80.57%> (ø)
pkg/descheduler/pod/pods.go 85.71% <85.71%> (ø)
pkg/descheduler/node/node.go 86.04% <86.04%> (ø)
pkg/descheduler/evictions/evictions.go 90.90% <90.90%> (ø)
pkg/descheduler/utils/pod.go 96.96% <96.96%> (ø)
pkg/descheduler/utils/priority.go 100.00% <100.00%> (ø)
pkg/koordlet/runtimehooks/reconciler/reconciler.go 78.94% <0.00%> (-2.11%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 827bd6b...9d60728. Read the comment docs.

pkg/descheduler/utils/predicates.go Outdated Show resolved Hide resolved
pkg/descheduler/utils/priority.go Outdated Show resolved Hide resolved
pkg/descheduler/pod/qos.go Outdated Show resolved Hide resolved
Signed-off-by: Joseph <joseph.t.lee@outlook.com>
@eahydra eahydra force-pushed the implement_descheduling_framework branch from e9ea546 to 9d60728 Compare August 1, 2022 09:31
@hormes
Copy link
Member

hormes commented Aug 1, 2022

/lgtm
/approve

@koordinator-bot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hormes

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@eahydra eahydra merged commit 49fa42c into koordinator-sh:main Aug 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants