Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

apis: add allocateOnce in reservation #447

Conversation

saintube
Copy link
Member

@saintube saintube commented Aug 8, 2022

Signed-off-by: saintube saintube@foxmail.com

Ⅰ. Describe what this PR does

Update with allocateOnce API in Reservation.

Ⅱ. Does this pull request fix one issue?

#440

Ⅲ. Describe how to verify it

Ⅳ. Special notes for reviews

V. Checklist

  • I have written necessary docs and comments
  • I have added necessary unit tests and integration tests
  • All checks passed in make test

@saintube
Copy link
Member Author

saintube commented Aug 8, 2022

/assign @eahydra @hormes @jasonliu747 @buptcozy

@koordinator-bot
Copy link

@saintube: GitHub didn't allow me to assign the following users: buptcozy.

Note that only koordinator-sh members, repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time.
For more information please see the contributor guide

In response to this:

/assign @eahydra @hormes @jasonliu747 @buptcozy

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@codecov
Copy link

codecov bot commented Aug 8, 2022

Codecov Report

Merging #447 (806de21) into main (361c0c6) will increase coverage by 0.04%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main     #447      +/-   ##
==========================================
+ Coverage   67.88%   67.93%   +0.04%     
==========================================
  Files         137      137              
  Lines       14980    14980              
==========================================
+ Hits        10169    10176       +7     
+ Misses       4051     4044       -7     
  Partials      760      760              
Flag Coverage Δ
unittests 67.93% <ø> (+0.04%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/koordlet/runtimehooks/reconciler/reconciler.go 78.94% <0.00%> (+7.36%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@saintube saintube force-pushed the add-reservation-allocate-once-api branch from 618bcba to ad3c1c3 Compare August 8, 2022 04:32
Signed-off-by: saintube <saintube@foxmail.com>
@jasonliu747 jasonliu747 force-pushed the add-reservation-allocate-once-api branch from ad3c1c3 to 806de21 Compare August 8, 2022 06:57
Copy link
Member

@eahydra eahydra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@koordinator-bot koordinator-bot bot added the lgtm label Aug 8, 2022
@hormes
Copy link
Member

hormes commented Aug 8, 2022

/approve

@koordinator-bot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hormes

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@koordinator-bot koordinator-bot bot merged commit ce27726 into koordinator-sh:main Aug 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants