Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: extend golangci-lint timeout to 10m #461

Merged
merged 1 commit into from
Aug 10, 2022

Conversation

jasonliu747
Copy link
Member

Signed-off-by: Jason Liu jasonliu747@gmail.com

Ⅰ. Describe what this PR does

CI keeps failing due to timeout. This PR will extend golangci-lint timeout from 5m to 10m.
image

V. Checklist

  • I have written necessary docs and comments
  • I have added necessary unit tests and integration tests
  • All checks passed in make test

Signed-off-by: Jason Liu <jasonliu747@gmail.com>
@codecov
Copy link

codecov bot commented Aug 10, 2022

Codecov Report

Merging #461 (faf14d9) into main (1fd7484) will not change coverage.
The diff coverage is 0.00%.

@@           Coverage Diff           @@
##             main     #461   +/-   ##
=======================================
  Coverage   67.21%   67.21%           
=======================================
  Files         145      145           
  Lines       15261    15261           
=======================================
  Hits        10258    10258           
  Misses       4234     4234           
  Partials      769      769           
Flag Coverage Δ
unittests 67.21% <0.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
.../koordlet/runtimehooks/hooks/groupidentity/rule.go 83.96% <ø> (ø)
pkg/webhook/pod/mutating/mutating_handler.go 75.00% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@koordinator-bot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by:

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jasonliu747 jasonliu747 merged commit 25ddb0e into koordinator-sh:main Aug 10, 2022
@jasonliu747 jasonliu747 deleted the golangci-timeout branch August 10, 2022 08:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant