Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ADOPTERS: add iQIYI #465

Merged
merged 1 commit into from
Aug 11, 2022
Merged

Conversation

wangxiaoq
Copy link
Contributor

Signed-off-by: Wang Xiaoqiang wangxiaoqiang@qiyi.com

Ⅰ. Describe what this PR does

Add iQIYI adopter

Ⅱ. Does this pull request fix one issue?

NONE

Ⅲ. Describe how to verify it

Ⅳ. Special notes for reviews

V. Checklist

Signed-off-by: Wang Xiaoqiang <wangxiaoqiang@qiyi.com>
@wangxiaoq
Copy link
Contributor Author

ping @jasonliu747

@hormes
Copy link
Member

hormes commented Aug 11, 2022

Great, welcome to koordinator~

@jasonliu747
Copy link
Member

/lgtm
🚀🚀🚀

@codecov
Copy link

codecov bot commented Aug 11, 2022

Codecov Report

Merging #465 (977b1a6) into main (bdd719b) will increase coverage by 0.04%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main     #465      +/-   ##
==========================================
+ Coverage   67.17%   67.21%   +0.04%     
==========================================
  Files         145      145              
  Lines       15261    15261              
==========================================
+ Hits        10251    10258       +7     
+ Misses       4241     4234       -7     
  Partials      769      769              
Flag Coverage Δ
unittests 67.21% <ø> (+0.04%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/koordlet/runtimehooks/reconciler/reconciler.go 78.94% <0.00%> (+7.36%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@hormes
Copy link
Member

hormes commented Aug 11, 2022

/approve

@koordinator-bot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hormes

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@koordinator-bot koordinator-bot bot merged commit 28d739a into koordinator-sh:main Aug 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants