feature: support read args from KubeletConfiguration #470
Conversation
ZYecho
force-pushed
the
support-kubeletconfig
branch
2 times, most recently
from
abc8b3c
to
9c0f922
Compare
Codecov Report
@@ Coverage Diff @@
## main #470 +/- ##
==========================================
- Coverage 67.94% 67.17% -0.78%
==========================================
Files 137 146 +9
Lines 14980 15466 +486
==========================================
+ Hits 10178 10389 +211
- Misses 4042 4302 +260
- Partials 760 775 +15
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
|
/lgtm |
| if err != nil { | ||
| klog.Errorf("failed to load kubelet config, err: %v", err) | ||
| } else { | ||
| if len(cpuManagerPolicy.Options) == 0 { |
There was a problem hiding this comment.
kubelet use params in --config ${file} first?
There was a problem hiding this comment.
add a comment here: kubelet use args first
pkg/util/system/cpu_manager_linux.go
Outdated
| return "", fmt.Errorf("failed to parse kubelet's args, kubelet version may not support: %v", err) | ||
| } | ||
| if argsFilePath == "" { | ||
| return "", fmt.Errorf("failed to get config file path, --config is empty") |
There was a problem hiding this comment.
if kubelet not specifies --config, error logs will be overwhelming, so is the Parse func
| if err != nil { | ||
| klog.Errorf("failed to load kubelet config, err: %v", err) | ||
| } else { | ||
| if len(cpuManagerPolicy.Options) == 0 { |
There was a problem hiding this comment.
add a comment here: kubelet use args first
Signed-off-by: Yue Zhang <huaihuan.zy@alibaba-inc.com>
ZYecho
force-pushed
the
support-kubeletconfig
branch
from
9c0f922
to
a6cf233
Compare
|
New changes are detected. LGTM label has been removed. |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Signed-off-by: Yue Zhang <huaihuan.zy@alibaba-inc.com>
Signed-off-by: Yue Zhang huaihuan.zy@alibaba-inc.com
Ⅰ. Describe what this PR does
fix #457
Ⅱ. Does this pull request fix one issue?
Ⅲ. Describe how to verify it
Ⅳ. Special notes for reviews
V. Checklist
make test