-
Notifications
You must be signed in to change notification settings - Fork 312
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
koord-scheduler: reservation support allocateOnce #478
koord-scheduler: reservation support allocateOnce #478
Conversation
Codecov Report
@@ Coverage Diff @@
## main #478 +/- ##
==========================================
+ Coverage 67.98% 68.07% +0.09%
==========================================
Files 149 149
Lines 16251 16298 +47
==========================================
+ Hits 11048 11095 +47
- Misses 4381 4384 +3
+ Partials 822 819 -3
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
c00c244
to
eccb911
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
Signed-off-by: saintube <saintube@foxmail.com>
eccb911
to
4bb4e04
Compare
/lgtm |
/lgtm |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: hormes The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Signed-off-by: saintube saintube@foxmail.com
Ⅰ. Describe what this PR does
Reservation supports
allocateOnce
.Once a pod allocates an available reservation with
allocateOnce
set to true, the reservation will becomeSucceeded
and no longer allocatable to other owners.Ⅱ. Does this pull request fix one issue?
fixes #440
Ⅲ. Describe how to verify it
allocateOnce
set.Succeeded
.Ⅳ. Special notes for reviews
V. Checklist
make test