Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

koord-runtime-proxy: regard empty string for CpusetCpus and CpusetMem… #484

Merged
merged 1 commit into from
Aug 15, 2022

Conversation

honpey
Copy link
Contributor

@honpey honpey commented Aug 15, 2022

…s as valid

Ⅰ. Describe what this PR does

Ⅱ. Does this pull request fix one issue?

Ⅲ. Describe how to verify it

Ⅳ. Special notes for reviews

V. Checklist

  • I have written necessary docs and comments
  • I have added necessary unit tests and integration tests
  • All checks passed in make test

…s as valid

Signed-off-by: honpey <honpey@gmail.com>
@codecov
Copy link

codecov bot commented Aug 15, 2022

Codecov Report

Merging #484 (203f439) into main (ddffb65) will decrease coverage by 0.07%.
The diff coverage is 100.00%.

❗ Current head 203f439 differs from pull request most recent head e443f21. Consider uploading reports for the commit e443f21 to get more accurate results

@@            Coverage Diff             @@
##             main     #484      +/-   ##
==========================================
- Coverage   68.07%   67.99%   -0.08%     
==========================================
  Files         149      149              
  Lines       16298    16295       -3     
==========================================
- Hits        11095    11080      -15     
- Misses       4381     4392      +11     
- Partials      822      823       +1     
Flag Coverage Δ
unittests 67.99% <100.00%> (-0.08%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/runtimeproxy/resexecutor/cri/utils.go 87.23% <100.00%> (-0.40%) ⬇️
pkg/koordlet/runtimehooks/reconciler/reconciler.go 71.57% <0.00%> (-9.48%) ⬇️
pkg/util/httputil/reverseproxy.go 84.30% <0.00%> (-0.80%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@zwzhang0107
Copy link
Contributor

/lgtm

Copy link
Member

@jasonliu747 jasonliu747 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@hormes
Copy link
Member

hormes commented Aug 15, 2022

/approve

@koordinator-bot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hormes, jasonliu747

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants