Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor batch node resource update #485

Merged
merged 1 commit into from
Aug 15, 2022
Merged

refactor batch node resource update #485

merged 1 commit into from
Aug 15, 2022

Conversation

zwzhang0107
Copy link
Contributor

Signed-off-by: 佑祎 zzw261520@alibaba-inc.com

Ⅰ. Describe what this PR does

Ⅱ. Does this pull request fix one issue?

Ⅲ. Describe how to verify it

Ⅳ. Special notes for reviews

V. Checklist

  • I have written necessary docs and comments
  • I have added necessary unit tests and integration tests
  • All checks passed in make test

@codecov
Copy link

codecov bot commented Aug 15, 2022

Codecov Report

Merging #485 (991b3bf) into main (ddffb65) will decrease coverage by 0.04%.
The diff coverage is 76.92%.

@@            Coverage Diff             @@
##             main     #485      +/-   ##
==========================================
- Coverage   68.07%   68.02%   -0.05%     
==========================================
  Files         149      149              
  Lines       16298    16290       -8     
==========================================
- Hits        11095    11082      -13     
- Misses       4381     4385       +4     
- Partials      822      823       +1     
Flag Coverage Δ
unittests 68.02% <76.92%> (-0.05%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/slo-controller/noderesource/noderesource.go 80.16% <76.92%> (-3.56%) ⬇️
pkg/koordlet/runtimehooks/reconciler/reconciler.go 78.94% <0.00%> (-2.11%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Signed-off-by: 佑祎 <zzw261520@alibaba-inc.com>
@koordinator-bot koordinator-bot bot added size/L and removed size/M labels Aug 15, 2022
@hormes
Copy link
Member

hormes commented Aug 15, 2022

/lgtm
/approve

@koordinator-bot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hormes

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@koordinator-bot koordinator-bot bot merged commit 62d18e1 into koordinator-sh:main Aug 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants