koord-descheduler: enable allocateOnce when creating Reservation #494
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eahydra
requested review from
hormes and
saintube
and removed request for
FillZpp
Codecov Report
@@ Coverage Diff @@
## main #494 +/- ##
==========================================
+ Coverage 67.96% 68.04% +0.08%
==========================================
Files 150 150
Lines 16287 16294 +7
==========================================
+ Hits 11069 11088 +19
+ Misses 4394 4383 -11
+ Partials 824 823 -1
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
eahydra
force-pushed
the
descheduler_support_reservation_allocateonce
branch
from
5516ee5
to
ed18806
Compare
|
/hold |
eahydra
force-pushed
the
descheduler_support_reservation_allocateonce
branch
from
ed18806
to
7c8b39c
Compare
|
/hold cancel |
Signed-off-by: Joseph <joseph.t.lee@outlook.com>
eahydra
force-pushed
the
descheduler_support_reservation_allocateonce
branch
from
7c8b39c
to
1b1f0d6
Compare
eahydra
changed the title
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: hormes The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
saintube
reviewed
Aug 17, 2022
| @@ -690,7 +697,7 @@ func (r *Reconciler) waitForPendingPodScheduled(ctx context.Context, job *sev1al | |||
| klog.Errorf("Failed to delete reservation, MigrationJob: %s, err: %v", job.Name, err) | |||
| } | |||
|
|
|||
| job.Status.Phase = sev1alpha1.PodMigrationJobSucceed | |||
| job.Status.Phase = sev1alpha1.PodMigrationJobSucceeded | |||
There was a problem hiding this comment.
can we remove the TODO in L694
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Joseph joseph.t.lee@outlook.com
Ⅰ. Describe what this PR does
Ⅱ. Does this pull request fix one issue?
Ⅲ. Describe how to verify it
Ⅳ. Special notes for reviews
V. Checklist
make test