Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

koord-runtime-proxy: support inject env in proxy #503

Merged
merged 2 commits into from
Aug 18, 2022

Conversation

ZYecho
Copy link
Contributor

@ZYecho ZYecho commented Aug 18, 2022

Signed-off-by: Yue Zhang huaihuan.zy@alibaba-inc.com

Ⅰ. Describe what this PR does

Ⅱ. Does this pull request fix one issue?

Ⅲ. Describe how to verify it

Ⅳ. Special notes for reviews

V. Checklist

  • I have written necessary docs and comments
  • I have added necessary unit tests and integration tests
  • All checks passed in make test

@codecov
Copy link

codecov bot commented Aug 18, 2022

Codecov Report

Merging #503 (5bec094) into main (239d812) will decrease coverage by 0.02%.
The diff coverage is 58.62%.

@@            Coverage Diff             @@
##             main     #503      +/-   ##
==========================================
- Coverage   68.06%   68.04%   -0.03%     
==========================================
  Files         152      152              
  Lines       16414    16435      +21     
==========================================
+ Hits        11173    11183      +10     
- Misses       4408     4421      +13     
+ Partials      833      831       -2     
Flag Coverage Δ
unittests 68.04% <58.62%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/runtimeproxy/server/docker/handler.go 37.23% <0.00%> (-0.80%) ⬇️
pkg/runtimeproxy/server/docker/server.go 65.89% <25.00%> (-1.57%) ⬇️
pkg/runtimeproxy/resexecutor/cri/container.go 60.46% <60.00%> (ø)
pkg/runtimeproxy/server/docker/utils.go 87.11% <100.00%> (+1.11%) ⬆️
pkg/koordlet/runtimehooks/reconciler/reconciler.go 78.94% <0.00%> (-2.11%) ⬇️
pkg/util/httputil/reverseproxy.go 84.84% <0.00%> (-0.27%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@cheimu
Copy link
Member

cheimu commented Aug 18, 2022

/lgtm

Signed-off-by: Yue Zhang <huaihuan.zy@alibaba-inc.com>
@cheimu
Copy link
Member

cheimu commented Aug 18, 2022

/lgtm

@koordinator-bot koordinator-bot bot added the lgtm label Aug 18, 2022
@koordinator-bot koordinator-bot bot removed the lgtm label Aug 18, 2022
@hormes
Copy link
Member

hormes commented Aug 18, 2022

/lgtm
/approve

@koordinator-bot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hormes

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@hormes hormes merged commit 3c2b6ef into koordinator-sh:main Aug 18, 2022
@ZYecho ZYecho deleted the add-env branch August 18, 2022 11:22
@jasonliu747 jasonliu747 changed the title feature: support inject env in proxy koord-runtime-proxy: support inject env in proxy Aug 19, 2022
@jasonliu747 jasonliu747 added this to the v0.7 milestone Aug 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants