Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: move GeneratePodPatch under util package #504

Merged
merged 1 commit into from
Aug 19, 2022

Conversation

jasonliu747
Copy link
Member

Signed-off-by: Jason Liu jasonliu747@gmail.com

Ⅰ. Describe what this PR does

Ⅱ. Does this pull request fix one issue?

Ⅲ. Describe how to verify it

Ⅳ. Special notes for reviews

V. Checklist

  • I have written necessary docs and comments
  • I have added necessary unit tests and integration tests
  • All checks passed in make test

@codecov
Copy link

codecov bot commented Aug 19, 2022

Codecov Report

Merging #504 (ef77e53) into main (8e49802) will increase coverage by 0.01%.
The diff coverage is 84.61%.

@@            Coverage Diff             @@
##             main     #504      +/-   ##
==========================================
+ Coverage   68.03%   68.04%   +0.01%     
==========================================
  Files         152      153       +1     
  Lines       16435    16425      -10     
==========================================
- Hits        11181    11177       -4     
+ Misses       4419     4415       -4     
+ Partials      835      833       -2     
Flag Coverage Δ
unittests 68.04% <84.61%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...cheduler/plugins/nodenumaresource/plugin_helper.go 88.88% <ø> (+10.62%) ⬆️
pkg/scheduler/plugins/reservation/utils.go 77.14% <ø> (+1.03%) ⬆️
pkg/util/utils.go 78.26% <ø> (-11.08%) ⬇️
pkg/util/pod.go 58.97% <40.00%> (-1.30%) ⬇️
pkg/scheduler/plugins/reservation/plugin.go 76.90% <50.00%> (ø)
pkg/util/cpuset.go 94.23% <94.23%> (ø)
pkg/scheduler/plugins/nodenumaresource/plugin.go 70.11% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Signed-off-by: Jason Liu <jasonliu747@gmail.com>
@koordinator-bot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by:

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@koordinator-bot koordinator-bot bot merged commit 8d05e30 into koordinator-sh:main Aug 19, 2022
@jasonliu747 jasonliu747 deleted the utils branch August 24, 2022 03:18
@jasonliu747 jasonliu747 added this to the v0.7 milestone Aug 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant