Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

koord-runtime-proxy: add more test cases #511

Merged
merged 1 commit into from
Aug 23, 2022

Conversation

honpey
Copy link
Contributor

@honpey honpey commented Aug 23, 2022

Signed-off-by: honpey honpey@gmail.com

Ⅰ. Describe what this PR does

Ⅱ. Does this pull request fix one issue?

Ⅲ. Describe how to verify it

Ⅳ. Special notes for reviews

V. Checklist

  • I have written necessary docs and comments
  • I have added necessary unit tests and integration tests
  • All checks passed in make test

Copy link
Member

@jasonliu747 jasonliu747 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

make sure you also run make lint to find out possible lint errors before committing codes.

pkg/runtimeproxy/store/manager_test.go Outdated Show resolved Hide resolved
Signed-off-by: honpey <honpey@gmail.com>
@codecov
Copy link

codecov bot commented Aug 23, 2022

Codecov Report

Merging #511 (e2800b4) into main (256c96c) will decrease coverage by 0.01%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #511      +/-   ##
==========================================
- Coverage   68.04%   68.03%   -0.02%     
==========================================
  Files         153      155       +2     
  Lines       16425    16474      +49     
==========================================
+ Hits        11177    11208      +31     
- Misses       4415     4434      +19     
+ Partials      833      832       -1     
Flag Coverage Δ
unittests 68.03% <100.00%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/runtimeproxy/resexecutor/cri/pod.go 51.06% <100.00%> (+4.25%) ⬆️
pkg/runtimeproxy/store/manager.go 56.09% <100.00%> (ø)
pkg/koordlet/runtimehooks/reconciler/reconciler.go 71.57% <0.00%> (-7.37%) ⬇️
pkg/runtimeproxy/utils/utils.go 100.00% <0.00%> (ø)
pkg/util/httputil/reverseproxy.go 85.10% <0.00%> (+0.79%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@ZYecho
Copy link
Contributor

ZYecho commented Aug 23, 2022

/lgtm

Copy link
Member

@jasonliu747 jasonliu747 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@jasonliu747 jasonliu747 added this to the v0.7 milestone Aug 23, 2022
@hormes
Copy link
Member

hormes commented Aug 23, 2022

/approve

@koordinator-bot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hormes

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@koordinator-bot koordinator-bot bot merged commit 753551b into koordinator-sh:main Aug 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants