-
Notifications
You must be signed in to change notification settings - Fork 312
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
koord-runtime-proxy: add more test cases #511
koord-runtime-proxy: add more test cases #511
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
make sure you also run make lint
to find out possible lint errors before committing codes.
e2d0be8
to
f235121
Compare
Signed-off-by: honpey <honpey@gmail.com>
f235121
to
e2800b4
Compare
Codecov Report
@@ Coverage Diff @@
## main #511 +/- ##
==========================================
- Coverage 68.04% 68.03% -0.02%
==========================================
Files 153 155 +2
Lines 16425 16474 +49
==========================================
+ Hits 11177 11208 +31
- Misses 4415 4434 +19
+ Partials 833 832 -1
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
/lgtm |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: hormes The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Signed-off-by: honpey honpey@gmail.com
Ⅰ. Describe what this PR does
Ⅱ. Does this pull request fix one issue?
Ⅲ. Describe how to verify it
Ⅳ. Special notes for reviews
V. Checklist
make test