Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: not update status field when create NodeMetric #514

Merged
merged 2 commits into from
Aug 24, 2022

Conversation

huiwq1990
Copy link
Contributor

Signed-off-by: huiwq1990 huiwq1990@163.com

Ⅰ. Describe what this PR does

Ⅱ. Does this pull request fix one issue?

Ⅲ. Describe how to verify it

Ⅳ. Special notes for reviews

V. Checklist

  • I have written necessary docs and comments
  • I have added necessary unit tests and integration tests
  • All checks passed in make test

@jasonliu747
Copy link
Member

Hi @huiwq1990 thanks. Can you summarize this PR in description? Simply describe what this PR does briefly.

Signed-off-by: huiwq1990 <huiwq1990@163.com>
@huiwq1990
Copy link
Contributor Author

Hi @huiwq1990 thanks. Can you summarize this PR in description? Simply describe what this PR does briefly.

As status field is a sub resource, we should update it use UpdateStatus method. As we create the nodemetric cr by create, the assign will change anything.

@codecov
Copy link

codecov bot commented Aug 23, 2022

Codecov Report

Merging #514 (0dfab91) into main (e4cb966) will increase coverage by 0.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main     #514      +/-   ##
==========================================
+ Coverage   67.97%   67.99%   +0.01%     
==========================================
  Files         155      155              
  Lines       16533    16526       -7     
==========================================
- Hits        11239    11237       -2     
+ Misses       4460     4456       -4     
+ Partials      834      833       -1     
Flag Coverage Δ
unittests 67.99% <ø> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/slo-controller/nodemetric/nodemetric.go 53.84% <ø> (-16.16%) ⬇️
pkg/util/httputil/reverseproxy.go 85.10% <0.00%> (+0.79%) ⬆️
pkg/koordlet/runtimehooks/reconciler/reconciler.go 81.05% <0.00%> (+2.10%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@jasonliu747
Copy link
Member

/cc @zwzhang0107

@saintube
Copy link
Member

/lgtm

@hormes
Copy link
Member

hormes commented Aug 24, 2022

/approve

@koordinator-bot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hormes

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@koordinator-bot koordinator-bot bot removed the lgtm label Aug 24, 2022
@jasonliu747 jasonliu747 changed the title create not update status field feat: not update status field when create NodeMetric Aug 24, 2022
Copy link
Member

@jasonliu747 jasonliu747 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@koordinator-bot koordinator-bot bot added the lgtm label Aug 24, 2022
@koordinator-bot koordinator-bot bot merged commit b0d4e3b into koordinator-sh:main Aug 24, 2022
@huiwq1990 huiwq1990 deleted the feat-status branch August 26, 2022 02:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants