Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add quotaTreeWrapper and elasticQuota API #515

Merged
merged 1 commit into from
Aug 26, 2022

Conversation

xulinfei1996
Copy link
Contributor

Signed-off-by: xulinfei.xlf xulinfei.xlf@alibaba-inc.com

Ⅰ. Describe what this PR does

Ⅱ. Does this pull request fix one issue?

Ⅲ. Describe how to verify it

Ⅳ. Special notes for reviews

V. Checklist

  • I have written necessary docs and comments
  • I have added necessary unit tests and integration tests
  • All checks passed in make test

@codecov
Copy link

codecov bot commented Aug 24, 2022

Codecov Report

Merging #515 (c4495ae) into main (39d7d14) will increase coverage by 0.24%.
The diff coverage is 81.56%.

@@            Coverage Diff             @@
##             main     #515      +/-   ##
==========================================
+ Coverage   67.26%   67.51%   +0.24%     
==========================================
  Files         160      163       +3     
  Lines       16992    17350     +358     
==========================================
+ Hits        11430    11714     +284     
- Misses       4719     4780      +61     
- Partials      843      856      +13     
Flag Coverage Δ
unittests 67.51% <81.56%> (+0.24%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
apis/extension/elastic_quota.go 0.00% <0.00%> (ø)
...er/plugins/elasticquota/core/quota_tree_wrapper.go 84.66% <84.66%> (ø)
.../scheduler/plugins/elasticquota/core/quota_info.go 94.23% <94.23%> (ø)
pkg/koordlet/runtimehooks/reconciler/reconciler.go 71.57% <0.00%> (-9.48%) ⬇️
pkg/util/httputil/reverseproxy.go 85.10% <0.00%> (+0.26%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

apis/extension/scheduling.go Outdated Show resolved Hide resolved
apis/extension/scheduling.go Outdated Show resolved Hide resolved
apis/scheduling/config/types.go Outdated Show resolved Hide resolved
apis/scheduling/config/types.go Outdated Show resolved Hide resolved
cmd/koord-scheduler/app/options/options.go Outdated Show resolved Hide resolved
pkg/scheduler/plugins/elasticquota/core/quota_operator.go Outdated Show resolved Hide resolved
pkg/scheduler/plugins/elasticquota/core/quota_operator.go Outdated Show resolved Hide resolved
pkg/scheduler/plugins/elasticquota/core/quota_operator.go Outdated Show resolved Hide resolved
pkg/scheduler/plugins/elasticquota/core/quota_operator.go Outdated Show resolved Hide resolved
@jasonliu747 jasonliu747 added this to the v0.7 milestone Aug 25, 2022
Copy link
Member

@eahydra eahydra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@eahydra eahydra requested a review from hormes August 25, 2022 08:59
@eahydra
Copy link
Member

eahydra commented Aug 25, 2022

/lgtm

Signed-off-by: xulinfei.xlf <xulinfei.xlf@alibaba-inc.com>
@buptcozy
Copy link
Contributor

/LGTM

@koordinator-bot
Copy link

@buptcozy: changing LGTM is restricted to collaborators

In response to this:

/LGTM

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@hormes
Copy link
Member

hormes commented Aug 26, 2022

/lgtm
/approve

@koordinator-bot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: eahydra, hormes

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants