Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

koord-scheduler: fix succeeded reservation in scheduler cache #516

Conversation

saintube
Copy link
Member

@saintube saintube commented Aug 24, 2022

Signed-off-by: saintube saintube@foxmail.com

Ⅰ. Describe what this PR does

  1. fix the handler for succeeded reservations in the scheduler cache
  2. fix a potential panic when cleanup a reservation cannot get
  3. fix typos
  4. update codecov.yaml, set patch check optional

Ⅱ. Does this pull request fix one issue?

Ⅲ. Describe how to verify it

Ⅳ. Special notes for reviews

V. Checklist

  • I have written necessary docs and comments
  • I have added necessary unit tests and integration tests
  • All checks passed in make test

@codecov
Copy link

codecov bot commented Aug 24, 2022

Codecov Report

Merging #516 (dec91df) into main (afcc49b) will decrease coverage by 0.00%.
The diff coverage is 33.33%.

@@            Coverage Diff             @@
##             main     #516      +/-   ##
==========================================
- Coverage   67.95%   67.94%   -0.01%     
==========================================
  Files         155      155              
  Lines       16504    16504              
==========================================
- Hits        11215    11214       -1     
  Misses       4457     4457              
- Partials      832      833       +1     
Flag Coverage Δ
unittests 67.94% <33.33%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/scheduler/eventhandlers/reservation_handler.go 48.85% <27.27%> (ø)
...cheduler/plugins/reservation/garbage_collection.go 82.14% <100.00%> (ø)
pkg/util/httputil/reverseproxy.go 84.30% <0.00%> (-0.80%) ⬇️
pkg/koordlet/runtimehooks/reconciler/reconciler.go 81.05% <0.00%> (+2.10%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Member

@eahydra eahydra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

Signed-off-by: saintube <saintube@foxmail.com>
@saintube saintube force-pushed the fix-reservation-in-scheduler-cache branch from 14fe595 to dec91df Compare August 24, 2022 06:12
@hormes
Copy link
Member

hormes commented Aug 24, 2022

/lgtm
/approve

@koordinator-bot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: eahydra, hormes

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@koordinator-bot koordinator-bot bot merged commit 2fb4ad2 into koordinator-sh:main Aug 24, 2022
@jasonliu747 jasonliu747 added this to the v0.7 milestone Aug 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants