-
Notifications
You must be signed in to change notification settings - Fork 312
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
koord-manager: record configmap and pod qos unmarshal failed events #518
koord-manager: record configmap and pod qos unmarshal failed events #518
Conversation
…informer cache Signed-off-by: songtao98 <songtao2603060@gmail.com>
Signed-off-by: songtao98 <songtao2603060@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
建议 commit 之前在本地先执行 make lint fast-test
Codecov Report
@@ Coverage Diff @@
## main #518 +/- ##
=======================================
Coverage 67.96% 67.96%
=======================================
Files 155 155
Lines 16526 16576 +50
=======================================
+ Hits 11232 11266 +34
- Misses 4460 4472 +12
- Partials 834 838 +4
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Signed-off-by: songtao98 <songtao2603060@gmail.com>
/lgtm |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: hormes, jasonliu747 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
…informer cache
Signed-off-by: songtao98 songtao2603060@gmail.com
Ⅰ. Describe what this PR does
Basically add EventRecorder to each slo-controllers and use Eventf() to record unmarshal failed events when errors occur
Ⅱ. Does this pull request fix one issue?
fixes #482
Ⅲ. Describe how to verify it
Ⅳ. Special notes for reviews
V. Checklist
make test