Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

koord-manager: record configmap and pod qos unmarshal failed events #518

Merged

Conversation

songtao98
Copy link
Contributor

…informer cache

Signed-off-by: songtao98 songtao2603060@gmail.com

Ⅰ. Describe what this PR does

Basically add EventRecorder to each slo-controllers and use Eventf() to record unmarshal failed events when errors occur

Ⅱ. Does this pull request fix one issue?

fixes #482

Ⅲ. Describe how to verify it

Ⅳ. Special notes for reviews

V. Checklist

  • I have written necessary docs and comments
  • I have added necessary unit tests and integration tests
  • All checks passed in make test

…informer cache

Signed-off-by: songtao98 <songtao2603060@gmail.com>
Signed-off-by: songtao98 <songtao2603060@gmail.com>
Copy link
Member

@jasonliu747 jasonliu747 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

建议 commit 之前在本地先执行 make lint fast-test

@codecov
Copy link

codecov bot commented Aug 24, 2022

Codecov Report

Merging #518 (f33fbab) into main (b0d4e3b) will increase coverage by 0.00%.
The diff coverage is 72.38%.

@@           Coverage Diff           @@
##             main     #518   +/-   ##
=======================================
  Coverage   67.96%   67.96%           
=======================================
  Files         155      155           
  Lines       16526    16576   +50     
=======================================
+ Hits        11232    11266   +34     
- Misses       4460     4472   +12     
- Partials      834      838    +4     
Flag Coverage Δ
unittests 67.96% <72.38%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...slo-controller/nodemetric/nodemetric_controller.go 56.00% <0.00%> (-6.00%) ⬇️
pkg/slo-controller/nodeslo/nodeslo_controller.go 49.16% <25.00%> (+5.83%) ⬆️
...controller/noderesource/noderesource_controller.go 45.00% <33.33%> (ø)
...o-controller/config/colocation_cm_event_handler.go 75.86% <64.44%> (-8.76%) ⬇️
...slo-controller/nodeslo/nodeslo_cm_event_handler.go 80.68% <89.36%> (-0.28%) ⬇️
pkg/slo-controller/nodeslo/resource_strategy.go 84.74% <100.00%> (ø)
pkg/koordlet/runtimehooks/reconciler/reconciler.go 81.05% <0.00%> (+2.10%) ⬆️
... and 1 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Signed-off-by: songtao98 <songtao2603060@gmail.com>
@songtao98 songtao98 requested review from jasonliu747 and removed request for yihuifeng August 24, 2022 09:48
@jasonliu747
Copy link
Member

/cc @zwzhang0107 @saintube

@hormes
Copy link
Member

hormes commented Aug 24, 2022

/lgtm
/approve

@koordinator-bot koordinator-bot bot removed the lgtm label Aug 24, 2022
@hormes
Copy link
Member

hormes commented Aug 25, 2022

/lgtm
/approve

@koordinator-bot koordinator-bot bot added the lgtm label Aug 25, 2022
@koordinator-bot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hormes, jasonliu747

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@koordinator-bot koordinator-bot bot merged commit aaead0f into koordinator-sh:main Aug 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[proposal] slo-controller should record events when failed to unmarshal configmap or pod qos config annotation
3 participants