Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

apis: update Reservation kubebuilder:printcolumn comments #524

Conversation

eahydra
Copy link
Member

@eahydra eahydra commented Aug 25, 2022

Signed-off-by: Joseph joseph.t.lee@outlook.com

Ⅰ. Describe what this PR does

if apply the koordinator 0.6, kubectl cannot print the node field of Reservation, as the following:

$ kubectl get reservation
kubectl get reservation
NAME                                       PHASE   AGE   
ea8a865f-073b-4dbb-b383-7d4adb6e5439               9s 

after fixed,

kubectl get reservation
NAME                                   PHASE       AGE    NODE                  TTL     EXPIRES
bd62f3c2-4c14-40fb-ba5e-83a94cb7908b   Available   3m2s   cn-hangzhou.1.2.3.4   30m0s

Ⅱ. Does this pull request fix one issue?

Ⅲ. Describe how to verify it

Ⅳ. Special notes for reviews

V. Checklist

  • I have written necessary docs and comments
  • I have added necessary unit tests and integration tests
  • All checks passed in make test

Signed-off-by: Joseph <joseph.t.lee@outlook.com>
@codecov
Copy link

codecov bot commented Aug 25, 2022

Codecov Report

Merging #524 (bb88cdb) into main (2b44432) will increase coverage by 0.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main     #524      +/-   ##
==========================================
+ Coverage   67.23%   67.25%   +0.01%     
==========================================
  Files         159      159              
  Lines       16916    16916              
==========================================
+ Hits        11374    11377       +3     
+ Misses       4699     4697       -2     
+ Partials      843      842       -1     
Flag Coverage Δ
unittests 67.25% <ø> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/util/httputil/reverseproxy.go 85.10% <0.00%> (+0.79%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@saintube
Copy link
Member

/lgtm

@hormes
Copy link
Member

hormes commented Aug 25, 2022

/lgtm
/approve

@koordinator-bot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hormes

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@koordinator-bot koordinator-bot bot merged commit 0479786 into koordinator-sh:main Aug 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants