Add runtime hooks stage config flag #526
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: songtao98 <songtao2603060@gmail.com> pass unit tests Signed-off-by: songtao98 <songtao2603060@gmail.com>
songtao98
force-pushed
the
add_runtime_hooks_stage_arg
branch
from
6f0aa15
to
adb2b2b
Compare
Codecov Report
@@ Coverage Diff @@
## main #526 +/- ##
==========================================
+ Coverage 67.17% 67.24% +0.07%
==========================================
Files 160 160
Lines 16970 16980 +10
==========================================
+ Hits 11399 11418 +19
+ Misses 4724 4715 -9
Partials 847 847
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
7 tasks
zwzhang0107
reviewed
Aug 25, 2022
Signed-off-by: songtao98 <songtao2603060@gmail.com>
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: hormes The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: songtao98 songtao2603060@gmail.com
Ⅰ. Describe what this PR does
Add flag runtime-hooks-disable-stages for koordlet runtime hooks, through which users can decide which hook stages will be disabled
Ⅱ. Does this pull request fix one issue?
Ⅲ. Describe how to verify it
Ⅳ. Special notes for reviews
V. Checklist
make test