koord-scheduler: optimize the process after reservation scheduling fails #532
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #532 +/- ##
==========================================
- Coverage 67.24% 67.04% -0.20%
==========================================
Files 160 160
Lines 16992 16996 +4
==========================================
- Hits 11426 11395 -31
- Misses 4719 4752 +33
- Partials 847 849 +2
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
eahydra
force-pushed
the
fix_reservation_unschedulable_message
branch
from
c97c06b
to
be01564
Compare
eahydra
force-pushed
the
fix_reservation_unschedulable_message
branch
2 times, most recently
from
96f3780
to
d273315
Compare
… fails - Improve the readability of the Reservation scheduling failure message - Report FailedScheduling Event - Add UnschedulableQueue first to avoid frequent retry scheduling Signed-off-by: Joseph <joseph.t.lee@outlook.com>
eahydra
force-pushed
the
fix_reservation_unschedulable_message
branch
from
d273315
to
54cee79
Compare
saintube
reviewed
Aug 26, 2022
|
/lgtm |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: hormes The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Joseph joseph.t.lee@outlook.com
Ⅰ. Describe what this PR does
koord-scheduler: optimize the process after reservation scheduling fails
Ⅱ. Does this pull request fix one issue?
fix #530 #528 #534
Ⅲ. Describe how to verify it
Ⅳ. Special notes for reviews
V. Checklist
make test