Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add groupQuotaManager #541

Merged

Conversation

xulinfei1996
Copy link
Contributor

Signed-off-by: xulinfei.xlf xulinfei.xlf@alibaba-inc.com

Ⅰ. Describe what this PR does

Ⅱ. Does this pull request fix one issue?

Ⅲ. Describe how to verify it

Ⅳ. Special notes for reviews

V. Checklist

  • I have written necessary docs and comments
  • I have added necessary unit tests and integration tests
  • All checks passed in make test

@codecov
Copy link

codecov bot commented Aug 29, 2022

Codecov Report

Merging #541 (836bff2) into main (383fffa) will increase coverage by 0.59%.
The diff coverage is 83.26%.

@@            Coverage Diff             @@
##             main     #541      +/-   ##
==========================================
+ Coverage   68.33%   68.92%   +0.59%     
==========================================
  Files         159      161       +2     
  Lines       17891    18382     +491     
==========================================
+ Hits        12225    12669     +444     
- Misses       4762     4807      +45     
- Partials      904      906       +2     
Flag Coverage Δ
unittests 68.92% <83.26%> (+0.59%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
.../scheduler/plugins/elasticquota/core/quota_info.go 72.38% <54.87%> (-21.85%) ⬇️
...r/plugins/elasticquota/core/group_quota_manager.go 84.81% <84.81%> (ø)
...gins/elasticquota/core/runtime_quota_calculator.go 96.91% <89.28%> (ø)
...ticquota/core/scale_minquota_when_over_root_res.go 100.00% <100.00%> (ø)
pkg/util/httputil/reverseproxy.go 84.30% <0.00%> (-0.54%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

xulinfei1996 pushed a commit to xulinfei1996/koordinator that referenced this pull request Sep 1, 2022
Signed-off-by: xulinfei.xlf <xulinfei.xlf@alibaba-inc.com>
Copy link
Contributor

@buptcozy buptcozy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/LGTM

Copy link

@yihuifeng yihuifeng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/LGTM

goos: darwin
goarch: amd64
cpu: Intel(R) Core(TM) i7-9750H CPU @ 2.60GHz
BenchmarkGroupQuotaManager_RefreshRuntime-12   6393   211792 ns/op

Signed-off-by: xulinfei.xlf <xulinfei.xlf@alibaba-inc.com>
Copy link
Member

@eahydra eahydra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@hormes
Copy link
Member

hormes commented Sep 5, 2022

/approve

@koordinator-bot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: buptcozy, eahydra, hormes

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@koordinator-bot koordinator-bot bot merged commit 78a1191 into koordinator-sh:main Sep 5, 2022
@jasonliu747 jasonliu747 added this to the v0.7 milestone Sep 5, 2022
@xulinfei1996 xulinfei1996 deleted the group_quota_manager_ci branch September 14, 2022 01:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants