Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

koord-scheduler: export getDefaultNUMAAllocateStrategy #547

Conversation

ZiMengSheng
Copy link
Contributor

Ⅰ. Describe what this PR does

Ⅱ. Does this pull request fix one issue?

Ⅲ. Describe how to verify it

Ⅳ. Special notes for reviews

V. Checklist

  • I have written necessary docs and comments
  • I have added necessary unit tests and integration tests
  • All checks passed in make test

Signed-off-by: wangjianyu <zmsjianyu@gmail.com>
@ZiMengSheng ZiMengSheng force-pushed the export_GetDefaultNUMAAllocateStrategy branch from 6d70d9d to d5dd49c Compare August 29, 2022 09:15
Copy link
Member

@eahydra eahydra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@codecov
Copy link

codecov bot commented Aug 29, 2022

Codecov Report

Merging #547 (d5dd49c) into main (bd3a7e3) will increase coverage by 0.01%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #547      +/-   ##
==========================================
+ Coverage   67.38%   67.40%   +0.01%     
==========================================
  Files         163      163              
  Lines       17354    17354              
==========================================
+ Hits        11694    11697       +3     
+ Misses       4801     4799       -2     
+ Partials      859      858       -1     
Flag Coverage Δ
unittests 67.40% <100.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/scheduler/plugins/nodenumaresource/plugin.go 62.44% <100.00%> (ø)
pkg/util/httputil/reverseproxy.go 85.10% <0.00%> (+0.79%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@jasonliu747 jasonliu747 added this to the v0.7 milestone Aug 29, 2022
@koordinator-bot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by: eahydra, jasonliu747

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@koordinator-bot koordinator-bot bot merged commit 374a81b into koordinator-sh:main Aug 29, 2022
@ZiMengSheng ZiMengSheng deleted the export_GetDefaultNUMAAllocateStrategy branch January 13, 2023 03:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants