Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

koord-scheduler: improve reservation compatibility #550

Conversation

saintube
Copy link
Member

@saintube saintube commented Aug 29, 2022

Signed-off-by: saintube saintube@foxmail.com

Ⅰ. Describe what this PR does

  1. improve the compatibility of the resource reservation by
  • move reservation utility functions into pkg/util
  • add some helper functions for scheduler plugins easily supporting reservations

Ⅱ. Does this pull request fix one issue?

#96 #188

Ⅲ. Describe how to verify it

Ⅳ. Special notes for reviews

V. Checklist

  • I have written necessary docs and comments
  • I have added necessary unit tests and integration tests
  • All checks passed in make test

@codecov
Copy link

codecov bot commented Aug 29, 2022

Codecov Report

Merging #550 (4946301) into main (063ccd7) will decrease coverage by 0.39%.
The diff coverage is 51.66%.

❗ Current head 4946301 differs from pull request most recent head 72a798e. Consider uploading reports for the commit 72a798e to get more accurate results

@@            Coverage Diff             @@
##             main     #550      +/-   ##
==========================================
- Coverage   67.53%   67.14%   -0.40%     
==========================================
  Files         164      164              
  Lines       17566    17760     +194     
==========================================
+ Hits        11864    11925      +61     
- Misses       4831     4950     +119     
- Partials      871      885      +14     
Flag Coverage Δ
unittests 67.14% <51.66%> (-0.40%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/util/pod.go 60.27% <ø> (+1.29%) ⬆️
pkg/util/reservation.go 37.43% <37.43%> (ø)
pkg/util/utils.go 55.00% <52.94%> (-11.67%) ⬇️
pkg/scheduler/plugins/nodenumaresource/plugin.go 63.71% <66.66%> (+1.26%) ⬆️
pkg/scheduler/eventhandlers/reservation_handler.go 50.00% <69.23%> (ø)
pkg/scheduler/plugins/reservation/hook.go 78.52% <75.00%> (ø)
pkg/scheduler/plugins/reservation/plugin.go 79.57% <76.66%> (+1.38%) ⬆️
pkg/scheduler/plugins/reservation/rcache.go 88.98% <93.75%> (ø)
...cheduler/plugins/reservation/garbage_collection.go 82.14% <100.00%> (ø)
pkg/scheduler/plugins/reservation/utils.go 79.62% <100.00%> (+4.77%) ⬆️
... and 1 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@saintube saintube force-pushed the improve-reservation-compatibility branch 2 times, most recently from d20cef8 to 9b2bca5 Compare August 30, 2022 09:51
@saintube saintube force-pushed the improve-reservation-compatibility branch 4 times, most recently from 71e74f6 to 76eaa0c Compare August 31, 2022 03:26
@saintube saintube changed the title WIP: koord-scheduler: improve reservation compatibility koord-scheduler: improve reservation compatibility Aug 31, 2022
@saintube saintube force-pushed the improve-reservation-compatibility branch 2 times, most recently from cf7fa23 to 4822a2c Compare August 31, 2022 07:25
@saintube saintube requested review from eahydra and removed request for hormes August 31, 2022 07:26
Copy link
Member

@eahydra eahydra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Signed-off-by: saintube <saintube@foxmail.com>
@koordinator-bot koordinator-bot bot removed the lgtm label Aug 31, 2022
@saintube saintube force-pushed the improve-reservation-compatibility branch from 4946301 to 72a798e Compare August 31, 2022 07:48
@eahydra
Copy link
Member

eahydra commented Aug 31, 2022

/lgtm

@koordinator-bot koordinator-bot bot added the lgtm label Aug 31, 2022
@hormes
Copy link
Member

hormes commented Aug 31, 2022

/approve

@koordinator-bot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hormes

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants