Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix container cgroup comment #553

Merged
merged 1 commit into from
Aug 30, 2022

Conversation

huiwq1990
Copy link
Contributor

Signed-off-by: huiwq1990 huiwq1990@163.com

Ⅰ. Describe what this PR does

Ⅱ. Does this pull request fix one issue?

Ⅲ. Describe how to verify it

Ⅳ. Special notes for reviews

V. Checklist

  • I have written necessary docs and comments
  • I have added necessary unit tests and integration tests
  • All checks passed in make test

Signed-off-by: huiwq1990 <huiwq1990@163.com>
@codecov
Copy link

codecov bot commented Aug 30, 2022

Codecov Report

Merging #553 (bcfa561) into main (e3bccb0) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #553   +/-   ##
=======================================
  Coverage   67.40%   67.40%           
=======================================
  Files         164      164           
  Lines       17381    17381           
=======================================
  Hits        11716    11716           
  Misses       4804     4804           
  Partials      861      861           
Flag Coverage Δ
unittests 67.40% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/util/container.go 68.18% <ø> (ø)
pkg/koordlet/runtimehooks/reconciler/reconciler.go 78.94% <0.00%> (-2.11%) ⬇️
pkg/util/httputil/reverseproxy.go 84.84% <0.00%> (+0.53%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Member

@jasonliu747 jasonliu747 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@koordinator-bot koordinator-bot bot added the lgtm label Aug 30, 2022
@jasonliu747 jasonliu747 added this to the v0.7 milestone Aug 30, 2022
@hormes
Copy link
Member

hormes commented Aug 30, 2022

/approve

@koordinator-bot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hormes

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@koordinator-bot koordinator-bot bot merged commit 5532bbf into koordinator-sh:main Aug 30, 2022
@huiwq1990 huiwq1990 deleted the feat-comment branch September 16, 2022 12:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants