Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

koord-scheduler: fix CPUTopologyManager get&update race condition #555

Conversation

eahydra
Copy link
Member

@eahydra eahydra commented Aug 30, 2022

Signed-off-by: Joseph joseph.t.lee@outlook.com

Ⅰ. Describe what this PR does

koord-scheduler: fix CPUTopologyManager get&update race condition

  • T1: goroutineA get CPUTopologyOptions and modify
  • T1' goroutineB get CPUTopologyOptions, modify and update.
  • T2 then goroutineA updates the modified CPUTopologyOptions, the data that be updated by goroutineB is overridden by goroutineB.

Thanks @ZiMengSheng report the issue.

Ⅱ. Does this pull request fix one issue?

Ⅲ. Describe how to verify it

Ⅳ. Special notes for reviews

V. Checklist

  • I have written necessary docs and comments
  • I have added necessary unit tests and integration tests
  • All checks passed in make test

Signed-off-by: Joseph <joseph.t.lee@outlook.com>
@eahydra
Copy link
Member Author

eahydra commented Aug 30, 2022

/cc @ZiMengSheng

@koordinator-bot
Copy link

@eahydra: GitHub didn't allow me to request PR reviews from the following users: ZiMengSheng.

Note that only koordinator-sh members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

/cc @ZiMengSheng

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@jasonliu747 jasonliu747 added this to the v0.7 milestone Aug 30, 2022
@codecov
Copy link

codecov bot commented Aug 30, 2022

Codecov Report

Merging #555 (6c1a281) into main (e3bccb0) will decrease coverage by 0.04%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #555      +/-   ##
==========================================
- Coverage   67.40%   67.36%   -0.05%     
==========================================
  Files         164      164              
  Lines       17381    17385       +4     
==========================================
- Hits        11716    11711       -5     
- Misses       4804     4813       +9     
  Partials      861      861              
Flag Coverage Δ
unittests 67.36% <100.00%> (-0.05%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...r/plugins/nodenumaresource/cpu_topology_manager.go 100.00% <100.00%> (ø)
.../plugins/nodenumaresource/topology_eventhandler.go 56.70% <100.00%> (+0.91%) ⬆️
pkg/koordlet/runtimehooks/reconciler/reconciler.go 71.57% <0.00%> (-9.48%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@ZiMengSheng
Copy link
Contributor

/lgtm
/approve

@koordinator-bot
Copy link

@ZiMengSheng: changing LGTM is restricted to collaborators

In response to this:

/lgtm
/approve

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Copy link
Contributor

@ZiMengSheng ZiMengSheng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@koordinator-bot
Copy link

@ZiMengSheng: changing LGTM is restricted to collaborators

In response to this:

/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@hormes
Copy link
Member

hormes commented Aug 30, 2022

/approve

Copy link
Member

@jasonliu747 jasonliu747 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

niceeeeeeeeee!
/lgtm

@koordinator-bot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hormes, jasonliu747, ZiMengSheng

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@koordinator-bot koordinator-bot bot merged commit 6f93236 into koordinator-sh:main Aug 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants