Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

koord-scheduler: fix coSchedulingArgs json name #558

Merged

Conversation

Wenshiqi222
Copy link
Contributor

Signed-off-by: wenshiqi wen470366661@163.com
fix the CoeschedulingArgs name and json name

Ⅰ. Describe what this PR does

Ⅱ. Does this pull request fix one issue?

Ⅲ. Describe how to verify it

Ⅳ. Special notes for reviews

V. Checklist

  • I have written necessary docs and comments
  • I have added necessary unit tests and integration tests
  • All checks passed in make test

@koordinator-bot koordinator-bot bot added size/S and removed size/M labels Aug 30, 2022
@Wenshiqi222 Wenshiqi222 force-pushed the enhance_coescheduling_apis branch 2 times, most recently from 9100b0d to c1ea04e Compare August 30, 2022 12:44
@Wenshiqi222 Wenshiqi222 changed the title koord-scheduler: fix coeSchedulingArgs name and json koord-scheduler: fix coSchedulingArgs name and json Aug 30, 2022
@Wenshiqi222 Wenshiqi222 changed the title koord-scheduler: fix coSchedulingArgs name and json koord-scheduler: fix coSchedulingArgs json name Aug 30, 2022
@codecov
Copy link

codecov bot commented Aug 30, 2022

Codecov Report

Merging #558 (58c556b) into main (f42c6ea) will decrease coverage by 0.06%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main     #558      +/-   ##
==========================================
- Coverage   67.43%   67.37%   -0.07%     
==========================================
  Files         164      164              
  Lines       17432    17432              
==========================================
- Hits        11756    11744      -12     
- Misses       4814     4825      +11     
- Partials      862      863       +1     
Flag Coverage Δ
unittests 67.37% <ø> (-0.07%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/koordlet/runtimehooks/reconciler/reconciler.go 71.57% <0.00%> (-9.48%) ⬇️
pkg/util/httputil/reverseproxy.go 84.30% <0.00%> (-0.80%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Signed-off-by: wenshiqi <wen470366661@163.com>
@Wenshiqi222
Copy link
Contributor Author

/assign @hormes

@hormes
Copy link
Member

hormes commented Aug 31, 2022

/approve

@koordinator-bot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hormes

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@hormes
Copy link
Member

hormes commented Aug 31, 2022

/lgtm

@koordinator-bot koordinator-bot bot added the lgtm label Aug 31, 2022
@koordinator-bot koordinator-bot bot merged commit a49535f into koordinator-sh:main Aug 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants