Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

koord-descheduler: fix failed evict with StatefulSet Pod #559

Merged

Conversation

eahydra
Copy link
Member

@eahydra eahydra commented Aug 30, 2022

Signed-off-by: Joseph joseph.t.lee@outlook.com

Ⅰ. Describe what this PR does

  1. When evict StatefulSet pod via PodMigrationJob, koord-descheduler cannot confirm whether the Pod has been migrated successfully since the newly created Pod has the same name. So koord-descheduler should check if the evicting Pod's UID is different from the previous Pod.
  2. Also in the scene, the logic of check whether the Reservation reserved on same on with Pod is also invalid.

Ⅱ. Does this pull request fix one issue?

Ⅲ. Describe how to verify it

Ⅳ. Special notes for reviews

V. Checklist

  • I have written necessary docs and comments
  • I have added necessary unit tests and integration tests
  • All checks passed in make test

@eahydra eahydra added this to the v0.7 milestone Aug 30, 2022
@codecov
Copy link

codecov bot commented Aug 30, 2022

Codecov Report

Merging #559 (ff0c370) into main (f42c6ea) will decrease coverage by 0.09%.
The diff coverage is 49.31%.

@@            Coverage Diff             @@
##             main     #559      +/-   ##
==========================================
- Coverage   67.43%   67.34%   -0.10%     
==========================================
  Files         164      164              
  Lines       17432    17485      +53     
==========================================
+ Hits        11756    11776      +20     
- Misses       4814     4840      +26     
- Partials      862      869       +7     
Flag Coverage Δ
unittests 67.34% <49.31%> (-0.10%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/descheduler/controllers/migration/filter.go 7.69% <40.00%> (ø)
...kg/descheduler/controllers/migration/controller.go 62.11% <50.00%> (-1.50%) ⬇️
pkg/util/httputil/reverseproxy.go 84.30% <0.00%> (-0.80%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@eahydra eahydra force-pushed the fix_evict_with_statefulset_pod branch from ed7b29e to 5de6df1 Compare August 30, 2022 15:08
Signed-off-by: Joseph <joseph.t.lee@outlook.com>
@eahydra eahydra force-pushed the fix_evict_with_statefulset_pod branch from 5de6df1 to ff0c370 Compare August 31, 2022 02:46
@jasonliu747
Copy link
Member

/assign
I'll take a look later today~

@hormes
Copy link
Member

hormes commented Aug 31, 2022

/lgtm
/approve

@koordinator-bot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hormes

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@koordinator-bot koordinator-bot bot merged commit 2d3db4b into koordinator-sh:main Aug 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants