Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Update details about compatible existing GPU Pods #571

Conversation

eahydra
Copy link
Member

@eahydra eahydra commented Sep 1, 2022

Signed-off-by: Joseph joseph.t.lee@outlook.com

Ⅰ. Describe what this PR does

Update details about compatible existing GPU Pods.

Ⅱ. Does this pull request fix one issue?

Ⅲ. Describe how to verify it

Ⅳ. Special notes for reviews

V. Checklist

  • I have written necessary docs and comments
  • I have added necessary unit tests and integration tests
  • All checks passed in make test

@eahydra eahydra force-pushed the update_device_scheduling_proposal branch 2 times, most recently from 4aea82f to 4b2c39d Compare September 1, 2022 12:38
@eahydra eahydra requested a review from ZYecho September 1, 2022 12:40
@codecov
Copy link

codecov bot commented Sep 1, 2022

Codecov Report

Merging #571 (7577039) into main (2457041) will increase coverage by 0.27%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main     #571      +/-   ##
==========================================
+ Coverage   67.15%   67.43%   +0.27%     
==========================================
  Files         164      164              
  Lines       17819    17846      +27     
==========================================
+ Hits        11967    12035      +68     
+ Misses       4966     4921      -45     
- Partials      886      890       +4     
Flag Coverage Δ
unittests 67.43% <ø> (+0.27%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/runtimeproxy/resexecutor/cri/utils.go 89.56% <0.00%> (+2.33%) ⬆️
pkg/runtimeproxy/resexecutor/cri/container.go 72.59% <0.00%> (+12.12%) ⬆️
pkg/runtimeproxy/resexecutor/cri/pod.go 76.59% <0.00%> (+25.53%) ⬆️
pkg/util/json.go 100.00% <0.00%> (+100.00%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@eahydra eahydra force-pushed the update_device_scheduling_proposal branch 4 times, most recently from 29f4015 to 162802a Compare September 1, 2022 12:57
Signed-off-by: Joseph <joseph.t.lee@outlook.com>
@eahydra eahydra force-pushed the update_device_scheduling_proposal branch from d7a9d14 to 7577039 Compare September 2, 2022 07:37
@buptcozy
Copy link
Contributor

buptcozy commented Sep 2, 2022

/LGTM

Copy link
Member

@jasonliu747 jasonliu747 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Copy link
Contributor

@buptcozy buptcozy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/LGTM

@eahydra eahydra removed the request for review from yihuifeng September 2, 2022 09:40
@koordinator-bot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by: buptcozy, jasonliu747

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@koordinator-bot koordinator-bot bot merged commit fd05f4b into koordinator-sh:main Sep 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants