-
Notifications
You must be signed in to change notification settings - Fork 312
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: add tests for reservation utils #582
test: add tests for reservation utils #582
Conversation
/cc @jasonliu747 |
Codecov Report
@@ Coverage Diff @@
## main #582 +/- ##
==========================================
+ Coverage 67.91% 68.32% +0.41%
==========================================
Files 159 159
Lines 17891 17891
==========================================
+ Hits 12150 12224 +74
+ Misses 4836 4760 -76
- Partials 905 907 +2
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Can you also add some UTs for |
Signed-off-by: saintube <saintube@foxmail.com>
6b21eef
to
a8bb914
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: hormes, jasonliu747 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Signed-off-by: saintube saintube@foxmail.com
Ⅰ. Describe what this PR does
add unit tests for reservation utility functions
Ⅱ. Does this pull request fix one issue?
Ⅲ. Describe how to verify it
Ⅳ. Special notes for reviews
V. Checklist
make test