Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: add tests for reservation utils #582

Merged
merged 1 commit into from
Sep 5, 2022

Conversation

saintube
Copy link
Member

@saintube saintube commented Sep 5, 2022

Signed-off-by: saintube saintube@foxmail.com

Ⅰ. Describe what this PR does

add unit tests for reservation utility functions

Ⅱ. Does this pull request fix one issue?

Ⅲ. Describe how to verify it

Ⅳ. Special notes for reviews

V. Checklist

  • I have written necessary docs and comments
  • I have added necessary unit tests and integration tests
  • All checks passed in make test

@saintube
Copy link
Member Author

saintube commented Sep 5, 2022

/cc @jasonliu747

@codecov
Copy link

codecov bot commented Sep 5, 2022

Codecov Report

Merging #582 (a8bb914) into main (198c812) will increase coverage by 0.41%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main     #582      +/-   ##
==========================================
+ Coverage   67.91%   68.32%   +0.41%     
==========================================
  Files         159      159              
  Lines       17891    17891              
==========================================
+ Hits        12150    12224      +74     
+ Misses       4836     4760      -76     
- Partials      905      907       +2     
Flag Coverage Δ
unittests 68.32% <ø> (+0.41%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/util/httputil/reverseproxy.go 85.10% <0.00%> (+0.26%) ⬆️
pkg/util/reservation.go 78.21% <0.00%> (+40.78%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@jasonliu747
Copy link
Member

Can you also add some UTs for IsReservationAvailable, IsReservationSucceeded, IsReservationFailed, and IsReservationExpired? Thanks.

Signed-off-by: saintube <saintube@foxmail.com>
Copy link
Member

@jasonliu747 jasonliu747 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@hormes
Copy link
Member

hormes commented Sep 5, 2022

/approve

@koordinator-bot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hormes, jasonliu747

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@koordinator-bot koordinator-bot bot merged commit 383fffa into koordinator-sh:main Sep 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants