Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

koord-scheduler: add elastic quota plugin #584

Merged

Conversation

xulinfei1996
Copy link
Contributor

@xulinfei1996 xulinfei1996 commented Sep 5, 2022

Signed-off-by: xulinfei.xlf xulinfei.xlf@alibaba-inc.com

Ⅰ. Describe what this PR does

Ⅱ. Does this pull request fix one issue?

fixes #202

Ⅲ. Describe how to verify it

Ⅳ. Special notes for reviews

V. Checklist

  • I have written necessary docs and comments
  • I have added necessary unit tests and integration tests
  • All checks passed in make test

@xulinfei1996 xulinfei1996 force-pushed the elastic-quota-plugin branch 5 times, most recently from b70ce72 to 3c6a10f Compare September 5, 2022 09:10
@codecov
Copy link

codecov bot commented Sep 5, 2022

Codecov Report

Base: 68.72% // Head: 68.96% // Increases project coverage by +0.23% 🎉

Coverage data is based on head (e7bcbb6) compared to base (76844b4).
Patch coverage: 69.97% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #584      +/-   ##
==========================================
+ Coverage   68.72%   68.96%   +0.23%     
==========================================
  Files         181      190       +9     
  Lines       21036    22051    +1015     
==========================================
+ Hits        14458    15207     +749     
- Misses       5582     5784     +202     
- Partials      996     1060      +64     
Flag Coverage Δ
unittests 68.96% <69.97%> (+0.23%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/scheduler/plugins/elasticquota/preempt.go 41.46% <41.46%> (ø)
pkg/scheduler/plugins/elasticquota/candidate.go 50.00% <50.00%> (ø)
...kg/scheduler/plugins/elasticquota/quota_handler.go 65.00% <65.00%> (ø)
pkg/scheduler/plugins/elasticquota/node_handler.go 67.18% <67.18%> (ø)
pkg/scheduler/plugins/elasticquota/controller.go 69.04% <69.04%> (ø)
pkg/scheduler/plugins/elasticquota/pod_handler.go 72.00% <72.00%> (ø)
pkg/scheduler/plugins/elasticquota/plugin.go 76.02% <76.02%> (ø)
...duler/plugins/elasticquota/quota_overuse_revoke.go 78.44% <78.44%> (ø)
...kg/scheduler/plugins/elasticquota/plugin_helper.go 82.41% <82.41%> (ø)
...r/plugins/elasticquota/core/group_quota_manager.go 92.72% <87.71%> (+7.90%) ⬆️
... and 7 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

pkg/scheduler/plugins/elasticquota/plugin.go Outdated Show resolved Hide resolved
pkg/scheduler/plugins/elasticquota/plugin.go Outdated Show resolved Hide resolved
pkg/scheduler/plugins/elasticquota/plugin.go Outdated Show resolved Hide resolved
pkg/scheduler/plugins/elasticquota/plugin.go Outdated Show resolved Hide resolved
pkg/scheduler/plugins/elasticquota/plugin.go Outdated Show resolved Hide resolved
@xulinfei1996 xulinfei1996 force-pushed the elastic-quota-plugin branch 2 times, most recently from a983a42 to a5c2a13 Compare September 6, 2022 03:28
@xulinfei1996 xulinfei1996 force-pushed the elastic-quota-plugin branch 2 times, most recently from 594c6b7 to fc3526f Compare September 15, 2022 07:17
@xulinfei1996 xulinfei1996 force-pushed the elastic-quota-plugin branch 2 times, most recently from 8796285 to 809a0fb Compare September 15, 2022 07:33
@xulinfei1996 xulinfei1996 force-pushed the elastic-quota-plugin branch 2 times, most recently from 410dc43 to 3e42732 Compare September 15, 2022 08:23
Copy link
Member

@eahydra eahydra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Signed-off-by: xulinfei.xlf <xulinfei.xlf@alibaba-inc.com>
Copy link
Contributor

@buptcozy buptcozy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/LGTM

@hormes
Copy link
Member

hormes commented Sep 15, 2022

/approve

@koordinator-bot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: buptcozy, eahydra, hormes

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[proposal] support elastic quota
4 participants