koord-manager: add elastic quota webhook #585

xulinfei1996 · 2022-09-05T12:58:36Z

Signed-off-by: xulinfei.xlf xulinfei.xlf@alibaba-inc.com

Ⅰ. Describe what this PR does

Ⅱ. Does this pull request fix one issue?

Ⅲ. Describe how to verify it

Ⅳ. Special notes for reviews

V. Checklist

I have written necessary docs and comments
I have added necessary unit tests and integration tests
All checks passed in make test

codecov · 2022-09-06T02:29:59Z

Codecov Report

Base: 68.82% // Head: 68.78% // Decreases project coverage by -0.03% ⚠️

Coverage data is based on head (9560ef9) compared to base (ee9a26d).
Patch coverage: 70.43% of modified lines in pull request are covered.

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #585      +/-   ##
==========================================
- Coverage   68.82%   68.78%   -0.04%     
==========================================
  Files         196      203       +7     
  Lines       22323    22905     +582     
==========================================
+ Hits        15363    15756     +393     
- Misses       5883     6046     +163     
- Partials     1077     1103      +26

Flag	Coverage Δ
unittests	`68.78% <70.43%> (-0.04%)`	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
...r/plugins/elasticquota/core/group_quota_manager.go	`84.33% <0.00%> (-2.30%)`	⬇️
...k/elasticquota/plugin_check_quota_meta_validate.go	`0.00% <0.00%> (ø)`
pkg/webhook/elasticquota/quota_topology_check.go	`74.09% <74.09%> (ø)`
...hook/elasticquota/validating/validating_handler.go	`76.19% <76.19%> (ø)`
pkg/webhook/elasticquota/quota_handler.go	`79.31% <79.31%> (ø)`
pkg/webhook/pod/validating/validating_handler.go	`84.74% <79.31%> (-5.26%)`	⬇️
pkg/webhook/elasticquota/quota_topology.go	`83.49% <83.49%> (ø)`
.../webhook/elasticquota/mutating/mutating_handler.go	`83.87% <83.87%> (ø)`
pkg/webhook/elasticquota/pod_check.go	`85.71% <85.71%> (ø)`
...kg/scheduler/plugins/elasticquota/plugin_helper.go	`79.34% <100.00%> (-0.44%)`	⬇️
... and 4 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

pkg/webhook/elasticquota/quota_topology.go

pkg/webhook/elasticquota/validating/validating_handler.go

pkg/webhook/elasticquota/quota_topology_check.go

pkg/webhook/elasticquota/quota_handler.go

buptcozy

/LGTM

buptcozy

/LGTM

hormes · 2022-09-21T05:44:42Z

pkg/webhook/elasticquota/quota_topology.go

+		return fmt.Errorf("BUG quotaMap and quotaTree information out of sync, losed :%v", quotaName)
+	}
+
+	delete(qt.quotaHierarchyInfo[quotaInfo.ParentName], quotaName)


validate 里修改内部状态是否合适？

hormes · 2022-09-21T05:55:45Z

pkg/webhook/pod/validating/validating_handler.go

@@ -57,6 +63,12 @@ func (h *PodValidatingHandler) validatingPodFn(ctx context.Context, req admissio
 	}

 	allowed, reason, err = h.clusterColocationProfileValidatingPod(ctx, req)
+	if err == nil {
+		plugin := elasticquota.NewPlugin(h.Decoder, h.Client)
+		if err = plugin.ValidatePod(ctx, req); err != nil {


因为尝试在这里维护内部状态，那这个插件就需要放在最后了。（如果集群还存在其他 webhook 组件，Pod 依然可能存在被拒绝的情形，这时内部的状态如何补偿）

Signed-off-by: xulinfei.xlf <xulinfei.xlf@alibaba-inc.com>

hormes · 2022-09-21T11:21:45Z

/lgtm
/approve

koordinator-bot · 2022-09-21T11:21:55Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: buptcozy, hormes

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [hormes]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

koordinator-bot bot added the do-not-merge/work-in-progress label Sep 5, 2022

koordinator-bot bot requested review from eahydra, FillZpp and hormes September 5, 2022 12:58

koordinator-bot bot added the size/XXL label Sep 5, 2022

xulinfei1996 force-pushed the quota-webhook branch 3 times, most recently from 8d4d4af to 2374587 Compare September 6, 2022 02:21

xulinfei1996 force-pushed the quota-webhook branch from 2374587 to dceba0a Compare September 6, 2022 06:25

eahydra changed the title ~~koord-webhook: add elastic quota webhook~~ koord-manager: add elastic quota webhook Sep 6, 2022