Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

koodlet: fix resource in cri proxy response maybe nil for kubelet 1.18 #587

Merged
merged 1 commit into from
Sep 6, 2022
Merged

koodlet: fix resource in cri proxy response maybe nil for kubelet 1.18 #587

merged 1 commit into from
Sep 6, 2022

Conversation

zwzhang0107
Copy link
Contributor

@zwzhang0107 zwzhang0107 commented Sep 6, 2022

Ⅰ. Describe what this PR does

Ⅱ. Does this pull request fix one issue?

Ⅲ. Describe how to verify it

Ⅳ. Special notes for reviews

V. Checklist

  • I have written necessary docs and comments
  • I have added necessary unit tests and integration tests
  • All checks passed in make test

@zwzhang0107 zwzhang0107 changed the title koodlet: fix resource in cri proxy response maybe nil for kubelt 1.18 koodlet: fix resource in cri proxy response maybe nil for kubelet 1.18 Sep 6, 2022
Signed-off-by: 佑祎 <zzw261520@alibaba-inc.com>
@codecov
Copy link

codecov bot commented Sep 6, 2022

Codecov Report

Merging #587 (3cba466) into main (156848b) will decrease coverage by 0.49%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #587      +/-   ##
==========================================
- Coverage   68.74%   68.24%   -0.50%     
==========================================
  Files         166      170       +4     
  Lines       19444    19617     +173     
==========================================
+ Hits        13366    13387      +21     
- Misses       5130     5277     +147     
- Partials      948      953       +5     
Flag Coverage Δ
unittests 68.24% <100.00%> (-0.50%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...oordlet/runtimehooks/protocol/container_context.go 11.59% <100.00%> (ø)
pkg/koordlet/runtimehooks/protocol/pod_context.go 14.54% <100.00%> (ø)
pkg/koordlet/runtimehooks/protocol/protocol.go 7.14% <100.00%> (ø)
pkg/util/httputil/reverseproxy.go 84.30% <0.00%> (-0.80%) ⬇️
.../koordlet/runtimehooks/protocol/kubeqos_context.go 0.00% <0.00%> (ø)
...eduler/plugins/coscheduling/controller/podgroup.go 70.93% <0.00%> (+1.97%) ⬆️
pkg/koordlet/runtimehooks/reconciler/reconciler.go 81.05% <0.00%> (+2.10%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Member

@jasonliu747 jasonliu747 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@hormes
Copy link
Member

hormes commented Sep 6, 2022

/lgtm
/approve

@koordinator-bot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hormes

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@koordinator-bot koordinator-bot bot merged commit 2fc3c5a into koordinator-sh:main Sep 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants