koord-scheduler: fix Reservation normalize score #589
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eahydra
requested review from
saintube,
hormes and
jasonliu747
and removed request for
FillZpp and
yihuifeng
eahydra
changed the title
Signed-off-by: Joseph <joseph.t.lee@outlook.com>
eahydra
force-pushed
the
fix_reservation_normalize_score
branch
from
d7d7d24
to
9f8aeb3
Compare
Codecov Report
@@ Coverage Diff @@
## main #589 +/- ##
==========================================
- Coverage 67.11% 67.11% -0.01%
==========================================
Files 171 171
Lines 19659 19662 +3
==========================================
+ Hits 13195 13196 +1
- Misses 5516 5517 +1
- Partials 948 949 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
saintube
approved these changes
Sep 6, 2022
| @@ -310,10 +310,13 @@ func (p *Plugin) Score(ctx context.Context, cycleState *framework.CycleState, po | |||
| } | |||
|
|
|||
| func (p *Plugin) ScoreExtensions() framework.ScoreExtensions { | |||
| return nil | |||
| return p | |||
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: hormes, saintube The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Joseph joseph.t.lee@outlook.com
Ⅰ. Describe what this PR does
scheduling.koordinator.sh/reservation-orderⅡ. Does this pull request fix one issue?
Ⅲ. Describe how to verify it
Ⅳ. Special notes for reviews
V. Checklist
make test