Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

QoS Manager Framework #590

Merged
merged 6 commits into from
Sep 8, 2022
Merged

QoS Manager Framework #590

merged 6 commits into from
Sep 8, 2022

Conversation

stormgbs
Copy link
Member

@stormgbs stormgbs commented Sep 6, 2022

Ⅰ. Describe what this PR does

Implement of proposal https://github.com/koordinator-sh/koordinator/blob/main/docs/proposals/koordlet/20220615-qos-manager.md

Ⅱ. Does this pull request fix one issue?

Ⅲ. Describe how to verify it

Ⅳ. Special notes for reviews

V. Checklist

  • I have written necessary docs and comments
  • I have added necessary unit tests and integration tests
  • All checks passed in make test

Signed-off-by: stormgbs <stormgbs@gmail.com>
@codecov
Copy link

codecov bot commented Sep 6, 2022

Codecov Report

Merging #590 (ffaf9cf) into main (9746eaa) will increase coverage by 0.69%.
The diff coverage is 41.26%.

❗ Current head ffaf9cf differs from pull request most recent head a43a9d5. Consider uploading reports for the commit a43a9d5 to get more accurate results

@@            Coverage Diff             @@
##             main     #590      +/-   ##
==========================================
+ Coverage   67.12%   67.81%   +0.69%     
==========================================
  Files         171      179       +8     
  Lines       19662    20548     +886     
==========================================
+ Hits        13198    13935     +737     
- Misses       5515     5650     +135     
- Partials      949      963      +14     
Flag Coverage Δ
unittests 67.81% <41.26%> (+0.69%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/koordlet/qosmanager/manager.go 0.00% <0.00%> (ø)
pkg/koordlet/config/config.go 50.00% <24.00%> (-22.42%) ⬇️
.../koordlet/qosmanager/metricsquery/metrics_query.go 57.54% <57.54%> (ø)
pkg/koordlet/qosmanager/config/config.go 100.00% <100.00%> (ø)
pkg/koordlet/runtimehooks/reconciler/reconciler.go 78.94% <0.00%> (-2.11%) ⬇️
pkg/scheduler/plugins/deviceshare/plugin.go 90.96% <0.00%> (ø)
pkg/scheduler/plugins/deviceshare/device_cache.go 87.83% <0.00%> (ø)
pkg/scheduler/plugins/deviceshare/utils.go 100.00% <0.00%> (ø)
pkg/scheduler/plugins/deviceshare/pod_handler.go 100.00% <0.00%> (ø)
...kg/scheduler/plugins/deviceshare/device_handler.go 100.00% <0.00%> (ø)
... and 2 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@hormes
Copy link
Member

hormes commented Sep 8, 2022

/lgtm
/approve

@koordinator-bot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hormes

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@koordinator-bot koordinator-bot bot merged commit 0de7d7b into koordinator-sh:main Sep 8, 2022
@jasonliu747
Copy link
Member

jasonliu747 commented Sep 8, 2022

@hormes @stormgbs I don't feel comfortable to merge this PR into main at this point. We should checkout a new branch called qos-manager, and merge commits into it. In this way, we would still code review each commit. After finishing the refactor work, then we could merge qos-manager into main.

@eahydra @zwzhang0107 comments/suggestions are welcome.

jasonliu747 added a commit that referenced this pull request Sep 8, 2022
This reverts commit 0de7d7b.

Signed-off-by: Jason Liu <jasonliu747@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants