Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

koordlet: report kubelet reserved cpus #592

Merged

Conversation

eahydra
Copy link
Member

@eahydra eahydra commented Sep 7, 2022

Signed-off-by: Joseph joseph.t.lee@outlook.com

Ⅰ. Describe what this PR does

  1. Refactor the implementation of parsing kubelet command parameters and configuration files. Reuse some of the existing code in kubelet to implement complete parameter parsing logic. can be reused directly.
  2. Report the reserved CPUs by kubelet. Support reserved by scalar or specified.
  3. Add reservedCPUs in protocol KubeletCPUManagerPolicy.

Ⅱ. Does this pull request fix one issue?

Ⅲ. Describe how to verify it

Ⅳ. Special notes for reviews

V. Checklist

  • I have written necessary docs and comments
  • I have added necessary unit tests and integration tests
  • All checks passed in make test

@eahydra eahydra changed the title support report kubelet reserved cpus report kubelet reserved cpus Sep 7, 2022
@codecov
Copy link

codecov bot commented Sep 7, 2022

Codecov Report

Merging #592 (9891d0a) into main (9891d0a) will not change coverage.
The diff coverage is n/a.

❗ Current head 9891d0a differs from pull request most recent head c79631c. Consider uploading reports for the commit c79631c to get more accurate results

@@           Coverage Diff           @@
##             main     #592   +/-   ##
=======================================
  Coverage   69.01%   69.01%           
=======================================
  Files         176      176           
  Lines       20358    20358           
=======================================
  Hits        14051    14051           
  Misses       5348     5348           
  Partials      959      959           
Flag Coverage Δ
unittests 69.01% <0.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@eahydra eahydra force-pushed the report_kubelet_reserved_cpu branch 4 times, most recently from 019e3ad to eb2fc32 Compare September 7, 2022 11:08
@eahydra eahydra marked this pull request as ready for review September 7, 2022 11:08
@eahydra eahydra requested review from ZYecho, jasonliu747, hormes, saintube and zwzhang0107 and removed request for FillZpp September 7, 2022 11:08
@eahydra eahydra changed the title report kubelet reserved cpus koordlet: report kubelet reserved cpus Sep 7, 2022
@eahydra eahydra force-pushed the report_kubelet_reserved_cpu branch 2 times, most recently from d35bfba to 754be85 Compare September 7, 2022 11:57
cmd/koordlet/main.go Show resolved Hide resolved
pkg/util/kubelet/kubelet_test.go Show resolved Hide resolved
Signed-off-by: Joseph <joseph.t.lee@outlook.com>
@hormes
Copy link
Member

hormes commented Sep 8, 2022

/lgtm
/approve

@koordinator-bot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hormes

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@koordinator-bot koordinator-bot bot merged commit 44817a0 into koordinator-sh:main Sep 8, 2022
jasonliu747 added a commit that referenced this pull request Sep 8, 2022
This reverts commit 44817a0.

Signed-off-by: Jason Liu <liuhoyen.lhy@alibaba-inc.com>
jasonliu747 pushed a commit to jasonliu747/koordinator that referenced this pull request Sep 8, 2022
Signed-off-by: Joseph <joseph.t.lee@outlook.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants