Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add restful api for coscheduling #603

Conversation

Wenshiqi222
Copy link
Contributor

@Wenshiqi222 Wenshiqi222 commented Sep 8, 2022

Signed-off-by: wenshiqi wen470366661@163.com

Ⅰ. Describe what this PR does

add restful api for coscheduling

Ⅱ. Does this pull request fix one issue?

implements #600

Ⅲ. Describe how to verify it

Ⅳ. Special notes for reviews

V. Checklist

  • I have written necessary docs and comments
  • I have added necessary unit tests and integration tests
  • All checks passed in make test

@Wenshiqi222 Wenshiqi222 force-pushed the add_restfulapi_to_coscheduling branch 2 times, most recently from 1be1cee to b9710be Compare September 12, 2022 06:27
@codecov
Copy link

codecov bot commented Sep 12, 2022

Codecov Report

Merging #603 (37c44da) into main (7f599f7) will decrease coverage by 0.21%.
The diff coverage is 12.72%.

@@            Coverage Diff             @@
##             main     #603      +/-   ##
==========================================
- Coverage   68.94%   68.73%   -0.22%     
==========================================
  Files         178      179       +1     
  Lines       20850    20905      +55     
==========================================
- Hits        14376    14370       -6     
- Misses       5484     5539      +55     
- Partials      990      996       +6     
Flag Coverage Δ
unittests 68.73% <12.72%> (-0.22%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/scheduler/plugins/coscheduling/core/core.go 35.51% <0.00%> (-5.65%) ⬇️
pkg/scheduler/plugins/coscheduling/core/gang.go 76.34% <ø> (ø)
...g/scheduler/plugins/coscheduling/plugin_service.go 63.63% <63.63%> (ø)
pkg/koordlet/runtimehooks/reconciler/reconciler.go 71.57% <0.00%> (-7.37%) ⬇️
...eduler/plugins/coscheduling/controller/podgroup.go 68.96% <0.00%> (-1.98%) ⬇️
pkg/util/httputil/reverseproxy.go 84.30% <0.00%> (-0.54%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Signed-off-by: wenshiqi <wen470366661@163.com>
@hormes
Copy link
Member

hormes commented Sep 16, 2022

/lgtm
/approve

@koordinator-bot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hormes

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@koordinator-bot koordinator-bot bot merged commit cda2754 into koordinator-sh:main Sep 16, 2022
@eahydra eahydra linked an issue Sep 16, 2022 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[proposal] export coscheduling internal state via Restful API
3 participants