-
Notifications
You must be signed in to change notification settings - Fork 312
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
koord-scheduler: support debug scores #604
koord-scheduler: support debug scores #604
Conversation
f0e3ae8
to
a3854e7
Compare
Codecov Report
@@ Coverage Diff @@
## main #604 +/- ##
==========================================
- Coverage 68.95% 68.67% -0.29%
==========================================
Files 178 180 +2
Lines 20847 20997 +150
==========================================
+ Hits 14376 14419 +43
- Misses 5478 5582 +104
- Partials 993 996 +3
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
a3854e7
to
dc3cf73
Compare
dc3cf73
to
88b3373
Compare
/hold |
88b3373
to
06f64cd
Compare
/hold cancel |
Users can enable debug scores via flags -s, --debug-scores or set on demand via the following commands: curl -X PUT <leaderSchedulerIP>:<port>/debug/flags/s --data '100' Signed-off-by: Joseph <joseph.t.lee@outlook.com>
06f64cd
to
780357d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
Should this be put into a separate file, so that it may be possible to read this file through the http interface in the future? |
Very good advice. In fact, I have also considered this problem, but I want to provide a simple method to meet the needs of the most basic debug scores. Later, we will look at the feedback and needs of the community before deciding how to persist and query the results. |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: hormes, jasonliu747, saintube The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
koord-scheduler: support debug scores
Users can enable debug scores via flags -s, --debug-scores or set on demand via the following commands:
curl -X PUT leaderSchedulerIP:port/debug/flags/s --data '100'
Signed-off-by: Joseph joseph.t.lee@outlook.com
Ⅰ. Describe what this PR does
Users can enable debug scores via flags -s, --debug-scores or set on demand via the following commands:
and the scheduler will logging the following content with markdown style:
Ⅱ. Does this pull request fix one issue?
implements #462
Ⅲ. Describe how to verify it
Ⅳ. Special notes for reviews
V. Checklist
make test