koordlet: CPI collector for Interference Detection #622
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/hold |
hormes
reviewed
Sep 16, 2022
zwzhang0107
reviewed
Sep 21, 2022
songtao98
force-pushed
the
feature_interference_collect_metrics
branch
2 times, most recently
from
385b85a
to
6e8b7d9
Compare
zwzhang0107
reviewed
Sep 29, 2022
zwzhang0107
reviewed
Sep 29, 2022
songtao98
changed the title
songtao98
force-pushed
the
feature_interference_collect_metrics
branch
from
0dd3f3d
to
b6fe121
Compare
songtao98
force-pushed
the
feature_interference_collect_metrics
branch
4 times, most recently
from
ec7e4b9
to
989a88e
Compare
Codecov ReportBase: 68.74% // Head: 68.73% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #622 +/- ##
==========================================
- Coverage 68.74% 68.73% -0.01%
==========================================
Files 205 207 +2
Lines 23356 23726 +370
==========================================
+ Hits 16055 16308 +253
- Misses 6200 6289 +89
- Partials 1101 1129 +28
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
songtao98
force-pushed
the
feature_interference_collect_metrics
branch
from
b36210a
to
03ed56b
Compare
songtao98
force-pushed
the
feature_interference_collect_metrics
branch
from
03ed56b
to
b0fe218
Compare
songtao98
force-pushed
the
feature_interference_collect_metrics
branch
17 times, most recently
from
c2cfed0
to
3d3fbd0
Compare
songtao98
changed the title
songtao98
force-pushed
the
feature_interference_collect_metrics
branch
from
3d3fbd0
to
da851da
Compare
Signed-off-by: songtao98 <songtao2603060@gmail.com>
songtao98
force-pushed
the
feature_interference_collect_metrics
branch
from
da851da
to
7798b3e
Compare
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED Approval requirements bypassed by manually added approval. This pull-request has been approved by: jasonliu747 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: songtao98 songtao2603060@gmail.com
Ⅰ. Describe what this PR does
This PR is the first part of koordinator interference detection support, which implements CPI metric collect and store feature. Koordlet collects CPI once a minute in a 10 second time window and store it in metric cache on per container level for future usage.
Other codes will be commited continuously with other PRs.
Ⅱ. Does this pull request fix one issue?
Ⅲ. Describe how to verify it
Ⅳ. Special notes for reviews
V. Checklist
make test