Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

koord-scheduler:refine gang restful api for coscheduling #624

Merged

Conversation

buptcozy
Copy link
Contributor

Ⅰ. Describe what this PR does

Ⅱ. Does this pull request fix one issue?

Ⅲ. Describe how to verify it

Ⅳ. Special notes for reviews

V. Checklist

  • I have written necessary docs and comments
  • I have added necessary unit tests and integration tests
  • All checks passed in make test

@codecov
Copy link

codecov bot commented Sep 16, 2022

Codecov Report

Base: 68.86% // Head: 68.82% // Decreases project coverage by -0.04% ⚠️

Coverage data is based on head (e7c1683) compared to base (cda2754).
Patch coverage: 4.34% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #624      +/-   ##
==========================================
- Coverage   68.86%   68.82%   -0.05%     
==========================================
  Files         191      192       +1     
  Lines       22110    22107       -3     
==========================================
- Hits        15227    15216      -11     
- Misses       5823     5831       +8     
  Partials     1060     1060              
Flag Coverage Δ
unittests 68.82% <4.34%> (-0.05%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/scheduler/plugins/coscheduling/core/core.go 40.28% <0.00%> (+4.76%) ⬆️
pkg/scheduler/plugins/coscheduling/core/gang.go 76.34% <ø> (ø)
...cheduler/plugins/coscheduling/core/gang_summary.go 0.00% <0.00%> (ø)
...g/scheduler/plugins/coscheduling/plugin_service.go 63.63% <66.66%> (ø)
...eduler/plugins/coscheduling/controller/podgroup.go 68.96% <0.00%> (-1.98%) ⬇️
...r/plugins/elasticquota/core/group_quota_manager.go 91.40% <0.00%> (-1.40%) ⬇️
pkg/util/httputil/reverseproxy.go 85.10% <0.00%> (+0.79%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@buptcozy buptcozy changed the title refine gang restful api for coscheduling koord-scheduler:refine gang restful api for coscheduling Sep 16, 2022
@buptcozy buptcozy force-pushed the refine_gang_restful_api branch 6 times, most recently from c28bb87 to 7c5def7 Compare September 16, 2022 07:24
Copy link
Member

@eahydra eahydra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Copy link
Member

@eahydra eahydra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Copy link

@yihuifeng yihuifeng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Signed-off-by: yangzhang <bupt_cozy@126.com>
@hormes
Copy link
Member

hormes commented Sep 16, 2022

/lgtm
/approve

@koordinator-bot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: eahydra, hormes

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@koordinator-bot koordinator-bot bot merged commit 7285728 into koordinator-sh:main Sep 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants