-
Notifications
You must be signed in to change notification settings - Fork 312
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
koord-scheduler: support score schedulingPhase hook and multiple hook #627
koord-scheduler: support score schedulingPhase hook and multiple hook #627
Conversation
Codecov ReportBase: 68.86% // Head: 69.11% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #627 +/- ##
==========================================
+ Coverage 68.86% 69.11% +0.24%
==========================================
Files 191 191
Lines 22110 22119 +9
==========================================
+ Hits 15227 15288 +61
+ Misses 5823 5771 -52
Partials 1060 1060
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please add UT.
这是干什么的?能简单说一下不?asking for a friend. |
a12aa81
to
69c3e4b
Compare
69c3e4b
to
28690cd
Compare
Signed-off-by: wangjianyu <zmsjianyu@gmail.com>
28690cd
to
28ca5c3
Compare
主要是在调度插件被调用前后做一些事情。之前koordinator已经支持了FilterPhaseHook和PreFilterPhaseHook。这个PR工作是支持每个plugin调用前后可以执行多个hook,并且补充了ScorePhaseHook |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: eahydra, hormes The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Signed-off-by: wangjianyu zmsjianyu@gmail.com
Ⅰ. Describe what this PR does
SchedulingPhase hook can give us the ability to hook the PreFilter&Filter&Score plugins and hook plugin parameter and return value. In some over-commitment scenario, we can use this to give all plugins unified resource view.
We noticed koodinator have support PreFilter&Filter phase hook, but support only one hook each each phase. This PR supports multiple hook each phase and supplies score hook.
Ⅱ. Does this pull request fix one issue?
Ⅲ. Describe how to verify it
Ⅳ. Special notes for reviews
V. Checklist
make test