Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: panic on node nil #631

Merged
merged 1 commit into from
Sep 20, 2022
Merged

Conversation

guilhem
Copy link
Contributor

@guilhem guilhem commented Sep 16, 2022

No description provided.

Signed-off-by: Guilhem Lettron <guilhem@barpilot.io>
@codecov
Copy link

codecov bot commented Sep 16, 2022

Codecov Report

Base: 68.90% // Head: 68.86% // Decreases project coverage by -0.04% ⚠️

Coverage data is based on head (ba270f5) compared to base (576b076).
Patch has no changes to coverable lines.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #631      +/-   ##
==========================================
- Coverage   68.90%   68.86%   -0.05%     
==========================================
  Files         194      194              
  Lines       22180    22180              
==========================================
- Hits        15284    15275       -9     
- Misses       5832     5844      +12     
+ Partials     1064     1061       -3     
Flag Coverage Δ
unittests 68.86% <ø> (-0.05%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/koordlet/runtimehooks/reconciler/reconciler.go 71.57% <0.00%> (-7.37%) ⬇️
...eduler/plugins/coscheduling/controller/podgroup.go 68.96% <0.00%> (-1.98%) ⬇️
pkg/util/httputil/reverseproxy.go 84.84% <0.00%> (+0.53%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Member

@jasonliu747 jasonliu747 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@zwzhang0107
Copy link
Contributor

/lgtm

@koordinator-bot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by:

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@koordinator-bot koordinator-bot bot merged commit eb9762e into koordinator-sh:main Sep 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants