Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

koordlet: fix nvml init error #635

Merged
merged 1 commit into from
Sep 19, 2022

Conversation

eahydra
Copy link
Member

@eahydra eahydra commented Sep 19, 2022

Signed-off-by: Joseph joseph.t.lee@outlook.com

Ⅰ. Describe what this PR does

koordlet needs to parse kubelet flags and configuration to enhanced compatibility with kubelet, indirectly dependence cadvisor and github.com/mindprince/gonvml, but govml is not compatible with github.com/NVIDIA/go-nvml.

We should remove the dependency on github.com/mindprince/gonvml.

Ⅱ. Does this pull request fix one issue?

fix #630

Ⅲ. Describe how to verify it

Ⅳ. Special notes for reviews

V. Checklist

  • I have written necessary docs and comments
  • I have added necessary unit tests and integration tests
  • All checks passed in make test

Signed-off-by: Joseph <joseph.t.lee@outlook.com>
@eahydra eahydra added this to the v0.7 milestone Sep 19, 2022
@eahydra eahydra removed the request for review from FillZpp September 19, 2022 04:02
Copy link
Member

@jasonliu747 jasonliu747 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@hormes
Copy link
Member

hormes commented Sep 19, 2022

/approve

@koordinator-bot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hormes, jasonliu747

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@codecov
Copy link

codecov bot commented Sep 19, 2022

Codecov Report

Base: 68.90% // Head: 68.93% // Increases project coverage by +0.02% 🎉

Coverage data is based on head (211b6c0) compared to base (576b076).
Patch has no changes to coverable lines.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #635      +/-   ##
==========================================
+ Coverage   68.90%   68.93%   +0.02%     
==========================================
  Files         194      194              
  Lines       22180    22180              
==========================================
+ Hits        15284    15290       +6     
+ Misses       5832     5831       -1     
+ Partials     1064     1059       -5     
Flag Coverage Δ
unittests 68.93% <ø> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...eduler/plugins/coscheduling/controller/podgroup.go 68.96% <0.00%> (-1.98%) ⬇️
pkg/util/httputil/reverseproxy.go 84.84% <0.00%> (+0.53%) ⬆️
pkg/scheduler/plugins/elasticquota/controller.go 78.57% <0.00%> (+9.52%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@koordinator-bot koordinator-bot bot merged commit c646e20 into koordinator-sh:main Sep 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] nvml.DeviceGetCount() returns ERROR_FUNCTION_NOT_FOUND
3 participants